Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loan: add location pickup_name on dump #3450

Merged
merged 1 commit into from
Oct 3, 2023
Merged

loan: add location pickup_name on dump #3450

merged 1 commit into from
Oct 3, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr self-assigned this Aug 31, 2023
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Aug 31, 2023
@Garfield-fr Garfield-fr mentioned this pull request Aug 31, 2023
Merged
7 tasks
@Garfield-fr Garfield-fr force-pushed the zub-loan-pickup-name branch 2 times, most recently from 9302a41 to 8c8875e Compare August 31, 2023 08:20
@jma jma removed their request for review September 27, 2023 09:48
zannkukai
zannkukai approved these changes Sep 28, 2023
View reviewed changes
rero_ils/modules/loans/dumpers.py Outdated Show resolved Hide resolved
@PascalRepond
Copy link
Contributor

Tests

  • When validating a request for another lib from the requests view, the pickup-location has an error ERROR TypeError: o.item.loan.pickup_location is undefined
    image
  • In the pickup library when checking in an item that was in transit for pickup, some info is missing TypeError: o.item.loan is undefined
    image

@Garfield-fr Garfield-fr force-pushed the zub-loan-pickup-name branch 3 times, most recently from b104bef to 8355f1e Compare October 2, 2023 14:23
@Garfield-fr
loan: add location pickup name on circulation
0cc5f1f 
* Adds the location pickup_name field on circulation information.
* Closes rero#3433.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 93c9cff into rero:staging Oct 3, 2023
3 checks passed
@Garfield-fr Garfield-fr deleted the zub-loan-pickup-name branch October 10, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

@rerowep rerowep Awaiting requested review from rerowep

Assignees

@Garfield-fr Garfield-fr

Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circulation UI: display pickup location for at_desk check-in
5 participants
@Garfield-fr @PascalRepond @jma @zannkukai @rerowep