general: MainTitle as a pipe and test imports refactoring. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
5 times, most recently
from
aceaca5
to
fc8c7cf
Compare
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
2 times, most recently
from
8feca0d
to
232e7bd
Compare
AoNoOokami
approved these changes
Apr 24, 2020
|
Can you use a spell checker for you commit messages? |
jma
requested changes
Apr 27, 2020
projects/admin/src/app/circulation/patron/history/history-item/history-item.component.html
Outdated
Show resolved
Hide resolved
.../circulation/patron/patron-transactions/patron-transaction/patron-transaction.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/patron/pickup/pickup-item/pickup-item.component.html
Outdated
Show resolved
Hide resolved
...detail-view/acquisition-order-detail-view/order-lines/acquisition-order-lines.component.html
Outdated
Show resolved
Hide resolved
...il-view/acquisition-order-line-detail-view/acquisition-order-line-detail-view.component.html
Outdated
Show resolved
Hide resolved
...ts/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
232e7bd
to
712145e
Compare
zannkukai
changed the title
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
712145e
to
ba44863
Compare
jma
requested changes
Apr 28, 2020
projects/admin/src/app/circulation/patron/pickup/pickup-item/pickup-item.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/record/detail-view/person-detail-view/person-detail-view.component.html
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
ba44863
to
09120bb
Compare
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
09120bb
to
5268819
Compare
jma
requested changes
Apr 30, 2020
projects/admin/src/app/circulation/main-request/main-request.component.spec.ts
Show resolved
Hide resolved
projects/admin/src/app/circulation/patron/loan/loan.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/record/detail-view/item-detail-view/item-detail-view.component.ts
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
5268819
to
22fe130
Compare
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
2 times, most recently
from
abc1bf7
to
438678a
Compare
jma
approved these changes
May 3, 2020
...ects/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/record/detail-view/item-detail-view/item-detail-view.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/record/detail-view/library-detail-view/library-detail-view.component.ts
Outdated
Show resolved
Hide resolved
...ects/admin/src/app/record/detail-view/location-detail-view/location-detail-view.component.ts
Outdated
Show resolved
Hide resolved
iGormilhit
approved these changes
May 4, 2020
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
438678a
to
d86e367
Compare
* Refactoring MainTitleService as a pipe. It allows to use it more easely into components because we don't need to import the service and create a repetitive method in each component to get a document main title. * This commit also renamed the Checkin component test file according to component name (previously named Checkout). * Refactoring test 'spec.ts' files to limit imports and declarations. As main modules (AppModule and CirculationModules) already define many imports and declarations, use them into the 'spec.ts' file instead of a lot of single imports. * Refactor name of some private attributes adding a leading '_'. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#refactoring-main-title-pipe
branch
from
d86e367
to
d933474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into components because we don't need to import the service and create
a repetitive method in each component to get a document main title.
component name (previously named Checkout).
As main modules (AppModule and CirculationModules) already define
many imports and declarations, use them into the 'spec.ts' file
instead of a lot of single imports.
Code review check list