Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translations: use server side translations #271

Merged
merged 1 commit into from
May 26, 2020
Merged

translations: use server side translations #271

merged 1 commit into from
May 26, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented May 25, 2020 •
edited
Loading

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

Dependencies

How to test?

  • Deploy on rero-ils and check that all translations are there.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-translations branch 2 times, most recently from 2c9b1ff to b051ecf Compare May 25, 2020 08:23
This was referenced May 25, 2020
Merged
Merged
@jma jma marked this pull request as ready for review May 25, 2020 08:50
@jma jma requested a review from AoNoOokami May 25, 2020 08:50
@jma jma requested a review from iGormilhit May 25, 2020 10:10
@jma jma changed the title translations: add sever side translations translations: use server side translations May 25, 2020
@jma
translations: use server side translations
a41bee3 
* Adds new assets directory for the admin project.
* Moves translations files to the assets directories.
* Removes custom translations loader.
* Fixes bad translation string definition.
* Adds assets and backend translations URLs configurations.
* Removes useless manual translations.
* Fixes missing languages for translation extractions: ar, nl, es.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma requested a review from sebdeleze May 26, 2020 14:12
@jma jma merged commit 33ae600 into rero:dev May 26, 2020
@jma jma deleted the maj-translations branch July 14, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze Awaiting requested review from sebdeleze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @iGormilhit @AoNoOokami