translations: add translations API #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-ui-translations
branch
5 times, most recently
from
90f11d1 to
1480cbc
Compare
rerowep
approved these changes
May 19, 2020
iGormilhit
suggested changes
May 20, 2020
sebdeleze
reviewed
May 20, 2020
| @@ -82,7 +82,8 @@ def run(self): | |||
| 'rero-ils = rero_ils.modules.ext:REROILSAPP' | |||
| ], | |||
| 'invenio_base.api_apps': [ | |||
| 'rero-ils = rero_ils.modules.ext:REROILSAPP' | |||
| 'rero-ils = rero_ils.modules.ext:REROILSAPP', | |||
| 'invenio_i18n = invenio_i18n:InvenioI18N' | |||
sebdeleze
approved these changes
May 20, 2020
This was referenced May 25, 2020
* Adds a new HTTP endpoint to expose the python po based translations in JSON in order to use theses translations in single app application instead of duplicating the translations in several projects. * Fixes spelling in comment. * Exposes `invenio-i18n` to the uwsgi backend application. * Fixes tests with the `invenio-i18n` enabled for the backend application. * Removes useless template filters and their tests. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in JSON in order to use theses translations in single app application
instead of duplicates the translations in several projects.
invenio-i18nto the uwsgi API.invenio-i18nenabled for the API.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list