authorization: limit roles management using API #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#1523-librarian-authorizations
branch
from
ae605ec
to
1d1f4ac
Compare
Garfield-fr
approved these changes
Jun 17, 2020
zannkukai
force-pushed
the
zan-#1523-librarian-authorizations
branch
2 times, most recently
from
a82db7f
to
1b8718b
Compare
sebdeleze
approved these changes
Jun 17, 2020
zannkukai
force-pushed
the
zan-#1523-librarian-authorizations
branch
from
1b8718b
to
a0c990c
Compare
AoNoOokami
approved these changes
Jun 19, 2020
zannkukai
force-pushed
the
zan-#1523-librarian-authorizations
branch
2 times, most recently
from
b885e19
to
95e45a4
Compare
iGormilhit
approved these changes
Jun 25, 2020
This commit restricts the role management for patrons using the role management API. Depending of the API result, some roles could be disabled into the role field into the Patron form. If the current user has only the librarian role, then the library field from the patron form editor will be disabled and set by default to the current library from the current logged user. - Closes rero/rero-ils#930 Co-authored_by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#1523-librarian-authorizations
branch
from
95e45a4
to
0a1034c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restricts the role management for patrons using the role
management API. Depending of the API result, some roles could be
disabled into the role field.
Co-authored_by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1523?kanban-status=1224894
Dependencies
How to test?
Logged as a
system_librarianGo into the professional interface and try to edit a patron
A system_librarian should be able to manage all roles, no role should be disabled.
Logged as a
librarianGo into the professional interface and try to edit a patron
The
system_librarianrole should be displayed but disabled.Code review check list