Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorization: create role management API #1043

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

zannkukai
Copy link
Contributor

Creates an API to expose which roles could be managed by the current
logged user.
This commit also introduces a restriction to disallow the current user
to delete itself.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Why are you opening this PR?

Dependencies

  • rero/rero-ils-ui#

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai self-assigned this Jun 16, 2020
@zannkukai zannkukai added this to the v0.10.0 milestone Jun 16, 2020
@zannkukai zannkukai force-pushed the zan-#1523-librarian-authorization branch from d20c08f to 6f6c533 Compare June 16, 2020 19:05
@zannkukai zannkukai requested a review from BadrAly June 16, 2020 19:38
@zannkukai zannkukai marked this pull request as ready for review June 17, 2020 08:35
@zannkukai zannkukai force-pushed the zan-#1523-librarian-authorization branch 4 times, most recently from 26dc087 to c60c096 Compare June 24, 2020 14:18
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved

Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job for the two PRs 1043 and 1051



@pytest.fixture(scope="module")
def system_librarian_martigny2(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system_librarian2_martigny instead of system_librarian_martigny2

@zannkukai zannkukai force-pushed the zan-#1523-librarian-authorization branch from c60c096 to aa92cf9 Compare June 25, 2020 08:55
Creates an API to expose which roles could be managed by the current
logged user.
This commit also introduces a restriction to disallow the current user
to delete itself.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-#1523-librarian-authorization branch from aa92cf9 to 8a6904a Compare June 25, 2020 09:03
@zannkukai zannkukai merged commit fc2ca81 into rero:dev Jun 25, 2020
@zannkukai zannkukai deleted the zan-#1523-librarian-authorization branch June 25, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants