circulation: update request permissions #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
added
the
f: circulation
AoNoOokami
force-pushed
the
zaa-#1685-permissions-cancel-update-request
branch
from
021870d
to
b212aa6
Compare
iGormilhit
reviewed
Aug 24, 2020
sebdeleze
suggested changes
Aug 24, 2020
...n/src/app/record/detail-view/item-detail-view/item-transaction/item-transaction.component.ts
Outdated
Show resolved
Hide resolved
...n/src/app/record/detail-view/item-detail-view/item-transaction/item-transaction.component.ts
Outdated
Show resolved
Hide resolved
zannkukai
requested changes
Aug 24, 2020
...n/src/app/record/detail-view/item-detail-view/item-transaction/item-transaction.component.ts
Outdated
Show resolved
Hide resolved
* Updates permissions to allow to cancel a request and to update request pickup location when an item is in transit for pickup. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1685-permissions-cancel-update-request
branch
from
b212aa6
to
adbf48e
Compare
zannkukai
approved these changes
Aug 24, 2020
sebdeleze
approved these changes
Aug 24, 2020
iGormilhit
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
Task 1685 of US 1665
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):How to test?
Try to change the request pickup location of an item that is in transit for pickup.
Code review check list