circulation: fix change pickup location on loans #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Fixes a bug where change pickup location was allowed for in_transit_to_house loans and not allowed for in_transit_for_pickup loans. Fixes a bug when checkout on in_transit_to_house loans was not possible for patrons not owning the loan in_transit_to_house. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-fix-change-pickup-loc
branch
from
e51848b
to
a374a82
Compare
lauren-d
approved these changes
Aug 21, 2020
AoNoOokami
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where change pickup location was allowed
for in_transit_to_house loans and not allowed for
in_transit_for_pickup loans.
Fixes a bug when checkout on in_transit_to_house loans
was not possible for patrons not owning the loan
in_transit_to_house.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1691?kanban-status=1224894
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list