Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations: fix show more item link #370

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

zannkukai
Copy link
Contributor

On the professional interface, when displaying the detailed view of a
journal with lots of issues, a show more… link is collapsed by default
and the number of hidden issues is displayed. This messages was not well
formed for translations. This commit fix this problem.

Closes rero/rero-ils#1223

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai marked this pull request as ready for review September 17, 2020 07:49
On the professional interface, when displaying the detailed view of a
journal with lots of issues, a show more… link is collapsed by default
and the number of hidden issues is displayed. This messages was not well
formed for translations. This commit fix this problem.

Closes rero/rero-ils#1223

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 07e2716 into rero:dev Sep 21, 2020
@zannkukai zannkukai deleted the zan-fix-1223 branch October 2, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A wrong message appears on the document detailed view of the professional interface
4 participants