Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A wrong message appears on the document detailed view of the professional interface #1223

Closed
iGormilhit opened this issue Sep 15, 2020 · 0 comments · Fixed by rero/rero-ils-ui#370
Closed

A wrong message appears on the document detailed view of the professional interface #1223

iGormilhit opened this issue Sep 15, 2020 · 0 comments · Fixed by rero/rero-ils-ui#370
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: professional ui Professional interface translations Translations
Milestone
v0.12.0

Comments

@iGormilhit
Copy link

Describe the bug

On the professional interface, when displaying the detailed view of a journal with lots of issues, a show more… link is collapsed by default and the number of hidden issues is displayed. The string is provided by the following function:

https://github.com/rero/rero-ils-ui/blob/dev/projects/admin/src/app/record/detail-view/document-detail-view/holding/holding.component.ts#L165

The result is some combinations of "hidden", "issue" and "issues", which, once translated, can be rendered as "29 caché fascicules".

To Reproduce
Steps to reproduce the behavior:

  1. Go to ils.test.rero.ch, version v0.12.0rc.
  2. Log as a librarian (Astrid).
  3. Search for "Conférence : [revue semestrielle]" in the professional interface.
  4. Display its detailed view.
  5. See the string "(4 caché issues)".

Expected behavior

We should have either the string "hidden issue" or "hidden issues" to translate.

Context
Tell us on what server did you spotted the issue, using with browser.
@iGormilhit iGormilhit added translations Translations f: professional ui Professional interface bug Breaks something but is not blocking labels Sep 15, 2020
@iGormilhit iGormilhit added this to the v0.12.0 milestone Sep 15, 2020
@iGormilhit iGormilhit changed the title Write a full sentence: The edit button should not be activated for not logged in users. A wrong message appears on the document detailed view of the professional interface Sep 16, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Sep 16, 2020
@zannkukai
translations: fix show more item link
748577e 
On the professional interface, when displaying the detailed view of a
journal with lots of issues, a show more… link is collapsed by default
and the number of hidden issues is displayed. This messages was not well
formed for translations. This commit fix this problem.

Closes rero/rero-ils#1223

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Sep 16, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Sep 16, 2020
@zannkukai
translations: fix show more item link
67ec6aa 
On the professional interface, when displaying the detailed view of a
journal with lots of issues, a show more… link is collapsed by default
and the number of hidden issues is displayed. This messages was not well
formed for translations. This commit fix this problem.

Closes rero/rero-ils#1223

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Sep 21, 2020
@zannkukai
translations: fix show more item link
792e615 
On the professional interface, when displaying the detailed view of a
journal with lots of issues, a show more… link is collapsed by default
and the number of hidden issues is displayed. This messages was not well
formed for translations. This commit fix this problem.

Closes rero/rero-ils#1223

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Sep 21, 2020
@zannkukai
translations: fix show more item link
07e2716 
On the professional interface, when displaying the detailed view of a
journal with lots of issues, a show more… link is collapsed by default
and the number of hidden issues is displayed. This messages was not well
formed for translations. This commit fix this problem.

Closes rero/rero-ils#1223

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: professional ui Professional interface translations Translations
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

translations: fix show more item link zannkukai/rero-ils-ui
2 participants
@iGormilhit @zannkukai