Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data: implement local fields #418

Merged
merged 1 commit into from
Dec 9, 2020
Merged

data: implement local fields #418

merged 1 commit into from
Dec 9, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Nov 6, 2020 •
edited
Loading

  • Adds local fields on document, item and holdings (serial type).
  • Adds holdings informations on the detail screen.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Dependencies

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@Garfield-fr Garfield-fr marked this pull request as draft November 6, 2020 10:22
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 12, 2020
@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Nov 12, 2020
@iGormilhit iGormilhit changed the title Local fields (WIP) Local fields Nov 17, 2020
@iGormilhit iGormilhit changed the title Local fields data: implement local fields Nov 17, 2020
@iGormilhit iGormilhit changed the title data: implement local fields data: display local fields Nov 17, 2020
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 5 times, most recently from 88df64b to d9f004b Compare November 19, 2020 06:56
@Garfield-fr Garfield-fr changed the title data: display local fields local fields: allow librarian to add local fields Nov 19, 2020
@Garfield-fr Garfield-fr marked this pull request as ready for review November 19, 2020 09:00
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 3 times, most recently from b92e341 to aaa2bf3 Compare November 19, 2020 09:11
@iGormilhit iGormilhit changed the title local fields: allow librarian to add local fields data: implement local fields Nov 19, 2020
iGormilhit
iGormilhit approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 4 times, most recently from 7f68ae1 to ca9f241 Compare November 19, 2020 15:12
zannkukai
zannkukai requested changes Nov 20, 2020
View reviewed changes
projects/shared/src/lib/pipe/join.pipe.ts Show resolved Hide resolved
projects/admin/src/app/routes/local-fields-route.ts Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/local-field/local-field.component.ts Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/local-field/local-field.component.ts Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/local-field/local-field.component.ts Show resolved Hide resolved
projects/admin/src/app/record/detail-view/local-field/local-field.component.html Outdated Show resolved Hide resolved
...src/app/record/detail-view/document-detail-view/holding-detail/holding-detail.component.html Outdated Show resolved Hide resolved
...ts/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/api/local-field-api.service.ts Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 3 times, most recently from 33fdbe9 to a24cf78 Compare November 26, 2020 07:02
@zannkukai zannkukai self-requested a review December 1, 2020 14:57
jma
jma approved these changes Dec 9, 2020
View reviewed changes
projects/admin/src/app/api/local-field-api.service.ts Outdated Show resolved Hide resolved
projects/admin/src/app/api/local-field-api.service.ts Outdated Show resolved Hide resolved
projects/admin/src/app/guard/can-add-local-fields.guard.ts Outdated Show resolved Hide resolved
projects/admin/src/app/guard/can-add-local-fields.guard.ts Show resolved Hide resolved
projects/admin/src/app/api/local-field-api.service.ts Show resolved Hide resolved
...src/app/record/detail-view/document-detail-view/holding-detail/holding-detail.component.html Outdated Show resolved Hide resolved
...iew/holding-detail-view/serial-holding-detail-view/serial-holding-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/local-field/local-field.component.ts Outdated Show resolved Hide resolved
projects/admin/src/manual_translations.ts Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 2 times, most recently from a140c6b to 9f23048 Compare December 9, 2020 12:23
@Garfield-fr
data: implement local fields
b7b55ba 
* Adds local fields on document, item and holdings (serial type).
* Adds holdings informations on the detail screen.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit c790a71 into rero:dev Dec 9, 2020
@Garfield-fr Garfield-fr deleted the zub-local-fields branch December 9, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

Assignees
No one assigned
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @jma @iGormilhit @zannkukai @lauren-d