Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data: implements local fields #1410

Merged
merged 1 commit into from
Dec 9, 2020
Merged

data: implements local fields #1410

merged 1 commit into from
Dec 9, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Nov 6, 2020 •
edited
Loading

  • Adds local fields on document, item and holdings (serial type).
  • Adds the column 'type' to the $refs resolution.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Co-Authored-by: Aly Badr aly.badr@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@Garfield-fr Garfield-fr marked this pull request as draft November 6, 2020 08:19
@Garfield-fr Garfield-fr mentioned this pull request Nov 6, 2020
Merged
6 tasks
@iGormilhit iGormilhit changed the title resource: new local fields resource (WIP) data: add local fields resource Nov 17, 2020
@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Nov 17, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 17, 2020
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 13 times, most recently from befca2e to c8dad7d Compare November 19, 2020 16:27
@Garfield-fr Garfield-fr changed the title data: add local fields resource data: implements local fields Nov 19, 2020
@Garfield-fr Garfield-fr marked this pull request as ready for review November 20, 2020 05:16
BadrAly
BadrAly suggested changes Nov 20, 2020
View reviewed changes
rero_ils/modules/local_fields/README.rst Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/api.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/api.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/api.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/jsonschemas/local_fields/local_field-v0.0.1.json Outdated Show resolved Hide resolved
tests/fixtures/metadata.py Outdated Show resolved Hide resolved
rero_ils/modules/acq_order_lines/mappings/v7/acq_order_lines/acq_order_line-v0.0.1.json Show resolved Hide resolved
iGormilhit
iGormilhit approved these changes Nov 23, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@pronguen
Copy link
Contributor

This is a nice improvement! 👏

  • I cannot edit local fields, for ex. to add a new one, if the document/item/holdings already contains some. When I try to save, it spins forever.
  • Local fields not indexed (see Benoit's comment)
  • Are there fixtures?

@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 4 times, most recently from 16f2f9e to 9b95ad6 Compare November 30, 2020 14:48
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 5 times, most recently from 0ed3ba3 to 4a8b3d6 Compare December 1, 2020 06:46
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 3 times, most recently from d68a308 to f09c60a Compare December 1, 2020 08:49
@benerken
Copy link
Contributor

benerken commented Dec 1, 2020 •
edited
Loading

Test n°2 (2020-12-01)

  • Bug: the FIRST local field could not be empty ! (same problem for local fields at document/item/holding level)
    Ex: If you add a "local field 5" and local field 1 is empty, the spinner loops and the console returns this message:

image

  • Indexing of local fields at document level is working fine !
    but not for item/holding level (I don't know if it's expected)

@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 2 times, most recently from dfbd695 to f647925 Compare December 2, 2020 06:19
iGormilhit
iGormilhit suggested changes Dec 2, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit minor correction:
Adds the type column in the refs resolve. → Adds the column 'type' to the $refs resolution.

rero_ils/modules/local_fields/__init__.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/jsonschemas/__init__.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/jsonschemas/local_fields/local_field-v0.0.1.json Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/jsonschemas/local_fields/local_field-v0.0.1.json Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/mappings/__init__.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/mappings/v7/__init__.py Outdated Show resolved Hide resolved
rero_ils/modules/local_fields/permissions.py Outdated Show resolved Hide resolved
tests/ui/local_fields/conftest.py Outdated Show resolved Hide resolved
tests/ui/local_fields/test_local_fields_jsonresolver.py Outdated Show resolved Hide resolved
tests/ui/local_fields/test_local_fields_mapping.py Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-local-fields branch 2 times, most recently from 728d3ec to b9f68b1 Compare December 2, 2020 07:27
@Garfield-fr
data: implements local fields
9e0837d 
* Adds local fields on document, item and holdings (serial type).
* Adds the column 'type' to the $refs resolution.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@Garfield-fr Garfield-fr merged commit 7f5e0ff into rero:dev Dec 9, 2020
@Garfield-fr Garfield-fr deleted the zub-local-fields branch December 9, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@rerowep rerowep Awaiting requested review from rerowep

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees
No one assigned
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Garfield-fr @benerken @pronguen @iGormilhit @zannkukai @BadrAly @rerowep @lauren-d