Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: fix several UI issues. #446

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Conversation

zannkukai
Copy link
Contributor

Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
loan.pid instead of loan.item.pid.

Closes rero/rero-ils#1488
Correct some translation problems n the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Nov 26, 2020
@zannkukai zannkukai added the bug Breaks something, but is not blocking. label Nov 26, 2020
@zannkukai zannkukai added this to the v0.15.0 milestone Nov 26, 2020
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message minor correction:
Correct some translation problems n the detail document viewCorrects some translation problems in the detail document view

@zannkukai zannkukai force-pushed the zan-fix-ui-issue branch 5 times, most recently from f894ff4 to 4f6d5fc Compare November 30, 2020 17:09
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Corrects some translation problems in the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 2d40272 into rero:dev Dec 1, 2020
@zannkukai zannkukai deleted the zan-fix-ui-issue branch December 1, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something, but is not blocking.
Projects
None yet
4 participants