Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series statement, color content, mode of issuance should be translated on professional interface #1488

Closed
pronguen opened this issue Nov 23, 2020 · 1 comment · Fixed by rero/rero-ils-ui#446
Closed

Series statement, color content, mode of issuance should be translated on professional interface #1488

pronguen opened this issue Nov 23, 2020 · 1 comment · Fixed by rero/rero-ils-ui#446
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) translations Translations
Milestone
v0.15.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 23, 2020 •
edited by iGormilhit
Loading

Describe the bug

On professional interface, document detailed view (description tab), followings strings should be translated:

  • Series statement (the label)
  • Color content (the content, it is a code)
  • Mode of issuance (the content, it is a code)

To Reproduce
Open a document detailed view and add a series statement, a color content, a mode of issuance.

Expected behavior
They are translated.

Context

  • server: ils.test.rero.ch (v0.14.0)

Screenshots

image

Additional information
@pronguen pronguen added triage bug Breaks something but is not blocking translations Translations labels Nov 23, 2020
@pronguen pronguen changed the title Series statement should be translated on professional interface Series statement, color content, mode of issuance should be translated on professional interface Nov 23, 2020
@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Nov 24, 2020
@zannkukai zannkukai self-assigned this Nov 24, 2020
@zannkukai
Copy link
Contributor

The document JSON schema allows 2 values for color content : rdacc:1002, rdacc:1003. These string are not yet extracted for translation process. The PR #1494 correct this problem. Both terms will be available for extraction with v0.15

zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 24, 2020
@zannkukai
circulation: allow overriding exception
f793697 
Sometimes, restrictions can disallow to execute a circulation operation.
Adding the "override_blocking" parameter to the API url allows to bypass
all restrictions.

This commit also corrects some string for translations (color content
RDA codes)

Closes rero#1488

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 26, 2020
@zannkukai
general: fix several UI issues.
a82beea 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Correct some translation problems n the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Nov 26, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 26, 2020
@zannkukai
general: fix several UI issues.
8034a45 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Correct some translation problems on the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 30, 2020
@zannkukai
general: fix several UI issues.
3086def 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Correct some translation problems on the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 30, 2020
@zannkukai
general: fix several UI issues.
1afe3fb 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Correct some translation problems on the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 30, 2020
@zannkukai
general: fix several UI issues.
e60f98f 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Correct some translation problems on the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 30, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 30, 2020
@zannkukai
general: fix several UI issues.
f894ff4 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Correct some translation problems on the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 30, 2020
@zannkukai
general: fix several UI issues.
4f6d5fc 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Corrects some translation problems in the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Dec 1, 2020
@zannkukai
general: fix several UI issues.
b79719c 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Corrects some translation problems in the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Dec 1, 2020
@zannkukai
general: fix several UI issues.
2d40272 
Closes rero/rero-ils#1487
Fixes item link displayed on an overdue transaction. The link used the
`loan.pid` instead of `loan.item.pid`.

Closes rero/rero-ils#1488
Corrects some translation problems in the detail document view (in the
description tab).

Close rero/rero-ils#1482
Updates the pickup counter when a 'ready to pickup' item is checked out.

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) translations Translations
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

general: fix several UI issues. zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai