users: display keep_history for patron

[BadrAly]

In the patron detailed view, the new field
keep_history is displayed.

Co-Authored-by: Aly Badr aly.badr@rero.ch

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/us/1422?milestone=277700

Dependencies

rero/invenio-userprofiles#2
rero/rero-ils#1512

How to test?

Case 1:

• Login as system_librarian.
• Find any patron with completed circ transactions
• Edit the patron record and disable the keep_history field if enabled. (Note: if disabled already, then enable it and then disable it).
• Go back the patron page, you will not find the the circ history. they are anonymized (not visible anymore)

Case 2:

• Login as patron (simonetta or other).
• Make sure you have completed circ transactions in the history tab.
• Take a look at the Personal data tab (re-organiszed) and the new edit button to take you to the RERO_ID editor.
• disable the keep_history field if enabled. (Note: if disabled already, then enable it and then disable it).
• Go back the history tab, you will not find the the circ history. they are anonymized (not visible anymore)

Case 3:

• repeat any of the above cases for a completed circulation transaction that has still fees to pay.
• The transaction will not be anonymized
• Pay the fees and the transaction will be anonymized with the execution of the daily job @7h00

Case 4:

• Patron has the keep_history enabled. transaction older than 6 months will be anonymized

Case 5:

• Patron has keep_history disabled and no transactions are visiable.
• Patron enables the keep_history . The anonymized transactions will still be not visible.

Code review check list

• Commit message template compliance.
• Commit message without typos.
• File names.
• Functions names.
• Functions docstrings.
• Unnecessary commited files?
• Cypress tests successful?

[iGormilhit]

1. Question: do we actually want to edit the patron detailed view? Check User detailed view should be removed. rero-ils#1444
2. Commit message proposition:

user: display keep_history for patron

* Displays the new field keep_history in the patron detailed view.

[BadrAly]

Question: do we actually want to edit the patron detailed view? Check rero/rero-ils#1444

@iGormilhit this will be removed when the task rero/rero-ils#1444 is done

[benerken]

• First time: there is a discordance between public view and Pro view.
  Let's take Helder patron account (Public view) : he has a patron history disabled.
  

Edit the patron record in the professional interface. The Toggle is enabled.

• Second test: Update patron history (enable/disable) for Helder and it's OK now.
  Both views are correct : the toggle in the pro view + the flag in the public view.

[pronguen]

• Patron editor (professional)
  • "Keep history" instead of "History settings". It is a toggle so the user should be able to respond to the label by yes/no, enable/disable.
  • Description to correct: "If enabled, the loan history is saved for a maximum of six months. It is visible to the user and the library staff."
  • When adding a new patron, the "Keep history" should be disabled by default.
  • I could reproduce Benoit's problem of discordance between the detailed view and the editor (users: display keep_history for patron #447 (comment)). It is difficult to identify how to reproduce it.
• Patron account (professional):
  • add in the Profile tab the "Keep history" info (as it is done for the patron detailed view).
  • disabling the history as a librarian does not work: indeed it removes the current history, but the new loans are displayed again in the history. To reproduce: 1. Open a user with history enabled and checkouts. 2. Disable history. 3. See that history isn't displayed. 4. Add transactions. 5. See that they appear in history.
  • If disabled, the loan history should not be shown, even for loans with fees. The US says that the corresponding tab disabled. Another option is to display a message "The loan history is disabled."
• Patron account (public):
  • "Keep history" instead of "History settings". Don't put a label next to the green point. The account needs to have as little text as possible. See proposal below.
    
  • If disabled, the loan history should not be shown, even for loans with fees. The US says that the corresponding tab disabled. Another option is to display a message "The loan history is disabled."
• Patron editor (public).
  • "Keep History" > "Keep history"
  • Description to correct: "If enabled, ..."

[benerken]

• In the public view: login with Helder
  Go to "Mon compte" -> "Données Personnelles" : the history is disabled.

 Click on "Edit" -> In the editor, the "Keep history" is enabled by default.
 If the patron doesn't take care, he will re-enable its history 

It's linked to the fact that Helder account has not yet been modified.

Mana has done the same test with Alain. She has enabled/disabled its history and it works.
So, a patron account with an history already disabled has a problem when he edits its account (the flag is enabled)

@benerken it is a minor problem. The user_profile is not up to date after executing the setup. I will fix this.
But as you noticed once the patron is edited for the first time, all goes well