Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: add an external link to the mef authority #503

Merged
merged 1 commit into from
Feb 11, 2021
Merged

editor: add an external link to the mef authority #503

merged 1 commit into from
Feb 11, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Jan 27, 2021 •
edited
Loading

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Note: the test failed due to the ng-core dependency, but works in my local installation.

Why are you opening this PR?

Dependencies

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma jma force-pushed the maj-fix-editor-issues branch from ac6b31d to ad1501f Compare January 27, 2021 13:09
@jma jma changed the title inprogess: editor: add a external link to the mef authority Jan 27, 2021
@jma jma marked this pull request as ready for review January 27, 2021 13:51
@jma jma mentioned this pull request Jan 27, 2021
Merged
7 tasks
iGormilhit
iGormilhit reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message:

  • From a external to an external.
  • mef and url in caps: MEF, URL.

@iGormilhit iGormilhit changed the title editor: add a external link to the mef authority editor: add an external link to the mef authority Jan 28, 2021
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor UX User experience, ergonomy dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed labels Jan 28, 2021
@jma jma force-pushed the maj-fix-editor-issues branch 2 times, most recently from a1441af to e19fcfb Compare January 28, 2021 15:30
@iGormilhit iGormilhit added this to the v1.1.0 milestone Feb 1, 2021
@jma jma force-pushed the maj-fix-editor-issues branch from e19fcfb to 6ec0401 Compare February 9, 2021 11:03
@jma jma force-pushed the maj-fix-editor-issues branch 2 times, most recently from c2efd6f to 45d5f57 Compare February 10, 2021 14:43
@jma
editor: add an external link to the MEF authority
e2b0b3b 
* Closes rero/rero-ils#1598.
* Changes the schemaform URL to schemas.
* Uses ngx-formly 5.10.12.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-fix-editor-issues branch from 45d5f57 to e2b0b3b Compare February 11, 2021 06:28
@jma jma merged commit d6e407c into rero:dev Feb 11, 2021
@jma jma deleted the maj-fix-editor-issues branch February 11, 2021 06:53
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.1 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed f: editor Concerns editor based on JSON schema AND custom editor UX User experience, ergonomy
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.

Add authority link to contributor suggestions in the document editor
4 participants
@jma @Garfield-fr @iGormilhit @zannkukai