editor: adapt JSON schema form options

[jma]

• Adapts the JSONSchema form options for a new ng-core editor version.
• Changes the schemaform url to schemas to be more compliant with other
  RERO application.
• Closes Add a validation for field electronicLocator.url #1426.
• Closes Agent is difficult to understand in the provision activity of the document editor #1423.
• Closes Restrict pick-up in the location editor should be possible only if requests are enabled. #1366.
• Closes Add authority link to contributor suggestions in the document editor #1598.
• Closes Display optional repetitive field only once #1604.
• Closes Cannot add new fields to a duplicate bibliographic record #1601.
• Closes Display a hyper text link when adding a $ref link to another resource in the editor #1425.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Dependencies

• editor: add an external link to the mef authority  rero-ils-ui#503
• editor: fix issues ng-core#338

Code review check list

• Commit message template compliance.
• Commit message without typos.
• File names.
• Functions names.
• Functions docstrings.
• Unnecessary commited files?
• Cypress tests successful?

[iGormilhit]

In the commit message:

• Separate JSON from schema in the title.
• url to URL.

[JoelleDosimont]

Seems all right to me, except for #1423 where the term "agent" remains unchanged.

[jma]

Seems all right to me, except for #1423 where the term "agent" remains unchanged.

This will be fixed when the translations will be done.

[JoelleDosimont]

In the holding editor, when adding a fields "Notes" it doesn't appear with a + sign like in the item editor. See the screenshot :

[pronguen]

I tested it and everything works! The link in the autocomplete is a great improvement, and will have a real impact on the end user/cataloguer.

Two remarks:

1. Display a hyper text link when adding a $ref link to another resource in the editor #1425 is not really solved (except for MEF link)
   • the initial goal was not for MEF link but for $ref in general.
   • the other $ref are not displayed as links. Examples:
     • Resource "acq_order_lines": field document
     • Resource "document": field partOf.document
   • There is a confusion: in some cases, the link is intern to RERO ILS, in some other (MEF link) it is either to MEF or to IdRef/GND.
   • Can you take out this issue from the PR and put the label "needs info"?
2. Contributor autocomplete in document editor does not ignore diacritics #1462 seems to be solved. If yes, can you include it as solved in the PR?

[iGormilhit]

@jma @pronguen Is there a confusion between #1598 and #1425 ?

⚠️ The list of closed issues is not the same in the PR comment or in the commit message. Maybe it's on purpose, just be sure to close the right one with the commit message.

[jma]

@jma @pronguen Is there a confusion between #1598 and #1425 ?

⚠️ The list of closed issues is not the same in the PR comment or in the commit message. Maybe it's on purpose, just be sure to close the right one with the commit message.

This is a summary of issues for all the 3 PR for the testers.