Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict pick-up in the location editor should be possible only if requests are enabled. #1366

Closed
pronguen opened this issue Nov 4, 2020 · 0 comments · Fixed by #1647
Closed

Restrict pick-up in the location editor should be possible only if requests are enabled. #1366

pronguen opened this issue Nov 4, 2020 · 0 comments · Fixed by #1647
Assignees
@jma
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 4, 2020

How it works

In the location editor, it is currently possible to enable "Restrict pick-up", even if the requests are disabled.

Improvement suggestion

Toggle "Restrict pick-up" should depend on the activation of the requests for the location.
@pronguen pronguen added enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor triage p-Low Low priority labels Nov 4, 2020
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend and removed triage labels Nov 4, 2020
@jma jma self-assigned this Jan 27, 2021
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
in progress
6fabdcb 
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Jan 27, 2021
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
editor: adapt JSONSchema form options
61c77f2 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
editor: adapt JSONSchema form options
89dc517 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
editor: adapt JSONSchema form options
2a12c77 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
@jma
editor: adapt JSONSchema form options
54afc47 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
@jma
editor: adapt JSONSchema form options
cd0a2c3 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
@jma
editor: adapt JSONSchema form options
00270f9 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 1, 2021
@jma
editor: adapt JSON schema form options
53b76af 
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 1, 2021
@jma
editor: adapt JSON schema form options
87cbe2b 
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 9, 2021
@jma
editor: adapt JSON schema form options
6094692 
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 10, 2021
@jma
editor: adapt JSON schema form options
42a8acf 
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 11, 2021
@jma
editor: adapt JSON schema form options
1d92263 
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed in #1647 Feb 11, 2021
jma added a commit that referenced this issue Feb 11, 2021
@jma
editor: adapt JSON schema form options
73b977f 
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes #1426.
* Closes #1423.
* Closes #1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: adapt JSON schema form options jma/rero-ils
3 participants
@jma @iGormilhit @pronguen