Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document editor: some icons are on the right of the labels, some are on the right of the input field #1420

Closed
pronguen opened this issue Nov 9, 2020 · 1 comment
Closed

Document editor: some icons are on the right of the labels, some are on the right of the input field #1420

pronguen opened this issue Nov 9, 2020 · 1 comment
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority stale Stale or no longer relevant

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 9, 2020

How it works

In the document editor, some duplicate/delete/add icons are on the right of the labels, some are on the right of the input field (see screenshot). This is due to the data structure but is difficult to understand by the end user.

Improvement suggestion

All duplicate/delete/add icons are just next to the concerned label.

Screenshots
image
@pronguen pronguen added enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor pilot libraries labels Nov 9, 2020
@iGormilhit iGormilhit added p-Low Low priority and removed triage labels Nov 17, 2020
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
in progress
6fabdcb 
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Jan 27, 2021
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
editor: adapt JSONSchema form options
61c77f2 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
editor: adapt JSONSchema form options
89dc517 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
@jma
editor: adapt JSONSchema form options
2a12c77 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
@jma
editor: adapt JSONSchema form options
54afc47 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
@jma
editor: adapt JSONSchema form options
cd0a2c3 
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority stale Stale or no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iGormilhit @pronguen