Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent is difficult to understand in the provision activity of the document editor #1423

Closed
pronguen opened this issue Nov 9, 2020 · 1 comment · Fixed by #1647
Closed
Assignees
Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years) wording When text is concerned, label, message, actions…

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 9, 2020

How it works

Agent is difficult to understand in the provision activity of the document editor.

Improvement suggestion
The value stays bf:Agent but the label in the editor is replaced by "Publisher, printer, etc."

Screenshot

image

@pronguen pronguen added enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor pilot libraries wording When text is concerned, label, message, actions… labels Nov 9, 2020
@iGormilhit
Copy link

iGormilhit commented Nov 16, 2020

The document JSON schema is wrong : https://github.com/rero/rero-ils/blob/dev/rero_ils/modules/documents/jsonschemas/documents/document_provision_activity-v0.0.1.json#L155

"form": {
                  "type": "selectWithSort",
                  "options": [
                    {
                      "label": "Place",
                      "value": "bf:Place"
                    },
                    {
                      "label": "Agent",
                      "value": "bf:Agent"
                    },
                    {
                      "label": "Date",
                      "value": "Date"
                    }
                  ],

should be:

"form": {
                  "type": "selectWithSort",
                  "options": [
                    {
                      "label": "bf:Place",
                      "value": "bf:Place"
                    },
                    {
                      "label": "bf:Agent",
                      "value": "bf:Agent"
                    },
                    {
                      "label": "Date",
                      "value": "Date"
                    }
                  ],

And then in weblate, we can translate bf:Agent as we want. This is the case for many enumeration in the document JSON schema, and maybe elsewhere.

See https://github.com/rero/developer-resources/blob/master/data/jsonschema.md#enum

@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Nov 16, 2020
@jma jma self-assigned this Jan 27, 2021
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 27, 2021
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1420.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Jan 28, 2021
* Adapts the JSONSchema form options for a new ng-core editor version.
* Changes the schemaform url to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 1, 2021
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 1, 2021
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 9, 2021
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 10, 2021
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Feb 11, 2021
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes rero#1426.
* Closes rero#1423.
* Closes rero#1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed in #1647 Feb 11, 2021
jma added a commit that referenced this issue Feb 11, 2021
* Adapts the JSON schema form options for a new ng-core editor version.
* Changes the schemaform URL to schemas to be more compliant with other
  RERO application.
* Closes #1426.
* Closes #1423.
* Closes #1366.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years) wording When text is concerned, label, message, actions…
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants