Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeahead: remove HTML tags from suggestion #525

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

zannkukai
Copy link
Contributor

The ngx-bootstrap library doesn't allow html tags into typeahead
suggestion anymore.

Closes rero/rero-ils#1708

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added this to the v1.1.0 milestone Feb 22, 2021
@zannkukai zannkukai self-assigned this Feb 22, 2021
Copy link
Contributor

@lauren-d lauren-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in commit message "geenral" => "general"

@iGormilhit iGormilhit added the f: editor Concerns editor based on JSON schema AND custom editor label Feb 23, 2021
@iGormilhit iGormilhit changed the title geenral: remove html tags from typeahead suggestion typeahead: remove html tags from suggestion Feb 23, 2021
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit proposition:

typeahead: remove HTML tags from suggestion

* Fixes the typeahead suggestion as the ngx-bootstrap library doesn't
  allow HTML tags into typeahead suggestion anymore.
* Closes rero/rero-ils#1708.

@iGormilhit iGormilhit changed the title typeahead: remove html tags from suggestion typeahead: remove HTML tags from suggestion Feb 23, 2021
* Fixes the typeahead suggestion as the ngx-bootstrap library doesn't
  allow HTML tags into typeahead suggestion anymore.
* Closes rero/rero-ils#1708.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.2 Mar 1, 2021
@zannkukai zannkukai merged commit e2125f3 into rero:dev Mar 3, 2021
@zannkukai zannkukai deleted the zan-fix-issue-1709 branch March 3, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILL request form: patron wrongly displayed
5 participants