Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILL request form: patron wrongly displayed #1708

Closed
ManaDeweerdt opened this issue Feb 18, 2021 · 0 comments · Fixed by rero/rero-ils-ui#525
Closed

ILL request form: patron wrongly displayed #1708

ManaDeweerdt opened this issue Feb 18, 2021 · 0 comments · Fixed by rero/rero-ils-ui#525
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface p-Low Low priority
Milestone
v1.1.0

Comments

@ManaDeweerdt
Copy link
Contributor

Describe the bug

The suggestion of the requester name is wrongly displayed in the ILL form of the professional interface.

To Reproduce

  1. Go to User services > ILL request.
  2. Add a new request.
  3. Try to add a username.
  4. See error

Expected behavior

The requester name should be "Family name, Firstname".

Context

Screenshots

image
@ManaDeweerdt ManaDeweerdt added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking p-Low Low priority labels Feb 18, 2021
@ManaDeweerdt ManaDeweerdt changed the title ILL request: wrong display of the user ILL request form: wrong display of the user Feb 18, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 22, 2021
@zannkukai
geenral: remove html tags from typeahead suggestion
9c9cd86 
The ngx-bootstrap library doesn't allow html tags into typeahead
suggestion anymore.

Closes rero/rero-ils#1708

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Feb 22, 2021
Merged
7 tasks
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface and removed triage labels Feb 23, 2021
@iGormilhit iGormilhit modified the milestones: v1.0.1, v1.1.0 Feb 23, 2021
@iGormilhit iGormilhit changed the title ILL request form: wrong display of the user ILL request form: patron wrongly displayed Feb 23, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Feb 23, 2021
@zannkukai
typeahead: remove HTML tags from suggestion
5c11c8b 
* Fixes the typeahead suggestion as the ngx-bootstrap library doesn't
  allow HTML tags into typeahead suggestion anymore.
* Closes rero/rero-ils#1708.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.2.0 Mar 1, 2021
@zannkukai zannkukai self-assigned this Mar 3, 2021
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Mar 3, 2021
@zannkukai
typeahead: remove HTML tags from suggestion
e2125f3 
* Fixes the typeahead suggestion as the ngx-bootstrap library doesn't
  allow HTML tags into typeahead suggestion anymore.
* Closes rero/rero-ils#1708.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface p-Low Low priority
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

typeahead: remove HTML tags from suggestion zannkukai/rero-ils-ui
3 participants
@iGormilhit @zannkukai @ManaDeweerdt