Merging PR #545
Merged
Merging PR #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds new circulation polices editor with formly. * Removes circulation policies custom editor. * Changes api service with API term on file and class. * Changes use injector on route tool service. * Closes rero/rero-ils#1573 Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Reorganise the patron circulation fee tab adding the fees preview about the overdue loans. Use a vertical tabs design to keep good readability of all fees categories into the component. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* The patron fees total amount in now returned by the circulation informations API. Updates code to reflect this change. * Creates services to communicate with the backend Loan API to get the preview overdue linked to a loan. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Moves ItemStatus and IssueItemStatus class to shared project and correct import statements into projects. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Fixes some display problems about circulation policies detail view. * Closes rero/rero-ils#1389 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review check list