Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections: rename into "Exhibition/course" #563

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Apr 8, 2021

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Rename "Collection" in "Exhibition/course"

Dependencies

My PR depends on rero-ils's PR(s):

How to test?

  • Check if all the changes in "Exhibition/race" are effective.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma
Copy link
Contributor

jma commented Apr 13, 2021

Commit message Closes #xxx -> Closes rero/rero-ils#xxx

@iGormilhit iGormilhit changed the title general: rename "Collection" in "Exhibition/course" collections: rename into "Exhibition/course" Apr 20, 2021
* Closes rero/rero-ils#1672.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr merged commit 7b0cc31 into rero:dev Apr 20, 2021
@Garfield-fr Garfield-fr deleted the zub-collection branch May 6, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Collection" is renamed into "exhibition/course"
4 participants