Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collections: rename into "Exhibition/course" #1815

Merged
merged 1 commit into from
Apr 20, 2021
Merged

collections: rename into "Exhibition/course" #1815

merged 1 commit into from
Apr 20, 2021

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Rename "Collection" in "Exhibition/course"

How to test?

  • Check if all the changes in "Exhibition/race" are effective.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr mentioned this pull request Apr 8, 2021
Merged
7 tasks
@Garfield-fr Garfield-fr requested review from BadrAly, jma and lauren-d April 15, 2021 12:52
@iGormilhit iGormilhit changed the title general: rename "Collection" in "Exhibition/course" collections: rename into "Exhibition/course" Apr 20, 2021
@Garfield-fr
collections: rename into "Exhibition/course"
9bfb9cf 
* Closes rero#1672.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
iGormilhit
iGormilhit approved these changes Apr 20, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr requested a review from iGormilhit April 20, 2021 08:42
@Garfield-fr Garfield-fr merged commit 91e011a into rero:dev Apr 20, 2021
@zannkukai zannkukai mentioned this pull request Apr 27, 2021
Merged
7 tasks
@Garfield-fr Garfield-fr deleted the zub-collection branch May 6, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@jma jma Awaiting requested review from jma

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Collection" is renamed into "exhibition/course"
3 participants
@Garfield-fr @iGormilhit @lauren-d