Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: validate and check the identifier #568

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Apr 15, 2021

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

Dependencies

My PR depends on rero-ils's PR(s):

How to test?

  • Check form field "identified by"
  • Check import document

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@ThierryClavel
Copy link

ThierryClavel commented Apr 15, 2021

test sur la saisie ISBN EAN et ISSN + import sur ISBN EAN : OK le contrôle se fait mais pas sur l'ISBN avec tirets (ce qui doit être normal ?)
Par contre pour l'import d'un périodique avec ISSN (test sur Mimos) : le contrôle ne se fait pas : on dirait que l'ISSN n'est pas importé (on ne le voit pas dans la notice), ce qui expliquerait la chose

@Garfield-fr Garfield-fr force-pushed the zub-identified-by-wrapper branch 4 times, most recently from a18402e to 4fec0e0 Compare April 16, 2021 05:09
@Garfield-fr Garfield-fr changed the title document: check on the ISBN/ISSN type identifier and import function document: EAN/ISBN/ISSN/ISSN-L identifier check Apr 16, 2021
* Validates the EAN/ISBN/ISSN/ISSN-L identifier as it is entered in the
  document editor.
* Checks if the identifier already exists in the instance (non-blocking
  validation).
* Validates and checks all `identifiedyBy` fields of the document as it
  is imported.
* Closes rero/rero-ils#1664.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr changed the title document: EAN/ISBN/ISSN/ISSN-L identifier check documents: validate and check the identifier Apr 20, 2021
@Garfield-fr Garfield-fr merged commit 9f757c9 into rero:dev Apr 20, 2021
@Garfield-fr Garfield-fr deleted the zub-identified-by-wrapper branch May 6, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for duplicated identifier (ISBN/ISSN) in the document editor
4 participants