Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for duplicated identifier (ISBN/ISSN) in the document editor #1664

Closed
ManaDeweerdt opened this issue Feb 2, 2021 · 0 comments · Fixed by rero/rero-ils-ui#568
Closed

Check for duplicated identifier (ISBN/ISSN) in the document editor #1664

ManaDeweerdt opened this issue Feb 2, 2021 · 0 comments · Fixed by rero/rero-ils-ui#568
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.2.0

Comments

@ManaDeweerdt
Copy link
Contributor

How it works

Today, if we create a document or import a document, the system doesn't check through the isbn/issn if we already have the document.

Improvement suggestion

The system should be able to detect if we already have the document or not.
a) As we are cataloguing and we complete the identifier field, the system should display a warning message if the identifier already exists in the system.
b) When we select a document and try to import, the system should warn that the identifier is already used in the system.
Nice to have: add a link to the document with the same identifier.
@ManaDeweerdt ManaDeweerdt added enhancement Improvement of an existing feature triage p-Medium Medium priority (to be solved within 1-2 years) labels Feb 2, 2021
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor and removed triage labels Feb 3, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Mar 4, 2021
@pronguen pronguen removed this from the v1.3.0 milestone Mar 15, 2021
This was referenced Apr 9, 2021
Closed
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 9, 2021
@Garfield-fr
document: added validator on identified by
15465cd 
* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@jma jma added this to the v1.2.0 milestone Apr 14, 2021
@pronguen pronguen modified the milestones: v1.2.0, v1.3.0 Apr 14, 2021
@Garfield-fr Garfield-fr mentioned this issue Apr 15, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 15, 2021
@Garfield-fr
document: check on the ISBN/ISSN type identifier and import function
3f42336 
form: when an ISBN/ISSN identifier is entered on a document,
it is validated and searched in the instance to see if
a document with this reference exists (non-blocking validation).

When importing a document, all fields in the identifiedBy
field of the document are searched in the instance.

* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 16, 2021
@Garfield-fr
document: check on the ISBN/ISSN type identifier and import function
b7dc678 
form: when an ISBN/ISSN identifier is entered on a document,
it is validated and searched in the instance to see if
a document with this reference exists (non-blocking validation).

When importing a document, all fields in the identifiedBy
field of the document are searched in the instance.

* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 16, 2021
@Garfield-fr
document: check on the ISBN/ISSN type identifier and import function
7009af4 
form: when an ISBN/ISSN identifier is entered on a document,
it is validated and searched in the instance to see if
a document with this reference exists (non-blocking validation).

When importing a document, all fields in the identifiedBy
field of the document are searched in the instance.

* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 16, 2021
@Garfield-fr
document: check on the ISBN/ISSN type identifier and import function
a18402e 
form: when an ISBN/ISSN identifier is entered on a document,
it is validated and searched in the instance to see if
a document with this reference exists (non-blocking validation).

When importing a document, all fields in the identifiedBy
field of the document are searched in the instance.

* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 16, 2021
@Garfield-fr
document: check on the ISBN/ISSN type identifier and import function
4fec0e0 
form: when an ISBN/ISSN identifier is entered on a document,
it is validated and searched in the instance to see if
a document with this reference exists (non-blocking validation).

When importing a document, all fields in the identifiedBy
field of the document are searched in the instance.

* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 16, 2021
@Garfield-fr
document: EAN/ISBN/ISSN/ISSN-L identifier check
2f10537 
Form: when an EAN/ISBN/ISSN/ISSN-L identifier is entered on a document,
it is validated and searched in the instance to see if
a document with this reference exists (non-blocking validation).

When importing a document, all identifiedBy fields of the document
are searched in the instance.

* Closes rero/rero-ils#1664

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 20, 2021
@Garfield-fr
documents: validate and check the identifier
3b250a5 
* Validates the EAN/ISBN/ISSN/ISSN-L identifier as it is entered in the
  document editor.
* Checks if the identifier already exists in the instance (non-blocking
  validation).
* Validates and checks all `identifiedyBy` fields of the document as it
  is imported.
* Closes rero/rero-ils#1664.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Apr 20, 2021
@Garfield-fr
documents: validate and check the identifier
9f757c9 
* Validates the EAN/ISBN/ISSN/ISSN-L identifier as it is entered in the
  document editor.
* Checks if the identifier already exists in the instance (non-blocking
  validation).
* Validates and checks all `identifiedyBy` fields of the document as it
  is imported.
* Closes rero/rero-ils#1664.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit changed the title Document: check duplicated identifier (ISBN/ISSN) Check for duplicated identifier (ISBN/ISSN) in the document editor May 6, 2021
@iGormilhit iGormilhit modified the milestones: v1.3.0, v1.2.0 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

documents: validate and check the identifier Garfield-fr/rero-ils-ui
4 participants
@jma @iGormilhit @pronguen @ManaDeweerdt