items: add temporary location field #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: professional ui
Garfield-fr
force-pushed
the
zub-temporary-location-display
branch
from
d77e223
to
79d2ce7
Compare
lauren-d
approved these changes
Jul 1, 2021
zannkukai
reviewed
Jul 1, 2021
...l-view/document-detail-view/holding/default-holding-item/default-holding-item.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/record/detail-view/item-detail-view/item-detail-view.component.html
Show resolved
Hide resolved
zannkukai
approved these changes
Jul 1, 2021
iGormilhit
suggested changes
Jul 1, 2021
There was a problem hiding this comment.
Commit message proposition:
items: add temporary location field
* Displays the `temporary_location` field according to the
exhibitions/courses and temporary location cascade on the document
detailed view of the public interface.
* Displays the `temporary_location` field on the item detailed view of the
professional interface.
* Closes rero/rero-ils#2038.
79d2ce7
to
b19fe90
Compare
Garfield-fr
changed the title
iGormilhit
approved these changes
Jul 1, 2021
Garfield-fr
force-pushed
the
zub-temporary-location-display
branch
from
b19fe90
to
a286d30
Compare
* Displays the `temporary_location` field according to the exhibitions/courses and temporary location cascade on the document detailed view of the public interface. * Displays the `temporary_location` field on the item detailed view of the professional interface. * Closes rero/rero-ils#2038. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-temporary-location-display
branch
from
a286d30
to
28b0ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays the
temporary_locationfield according to theexhibitions/courses and temporary location cascade on the document
detailed view of the public interface.
Displays the
temporary_locationfield on the item detailed view of theprofessional interface.
Closes Field
item.temporary_locationis displayed in the public and professional interfaces rero-ils#2038.Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list