Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field item.temporary_location is displayed in the public and professional interfaces #2038

Closed
pronguen opened this issue Jun 15, 2021 · 2 comments · Fixed by rero/rero-ils-ui#652
Closed

Field item.temporary_location is displayed in the public and professional interfaces #2038

pronguen opened this issue Jun 15, 2021 · 2 comments · Fixed by rero/rero-ils-ui#652
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.4.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Jun 15, 2021 •
edited
Loading

How it works

Currently, the exhibition/course is displayed as "Temporary location" on

  • pro: document detailed view
  • public: document detailed view

Improvement suggestion

With the new field item.temporary_location, we need to display under the same label "Temporary location"

  • the linked exhibition/course
    • else: the temporary location
  • or both? TO CLARIFY BY PO GROUP

This applies to

  • pro: document detailed view
  • pro: item detailed view
  • public: document detailed view
@pronguen pronguen added enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months) labels Jun 15, 2021
@pronguen pronguen added this to the v1.4.0 milestone Jun 15, 2021
@zannkukai
Copy link
Contributor

According to Gitter "PO room" :

  • on affiche l'exposition/cours (+lien)
  • s'il n'y en a pas on affiche item.temporary_location
  • s'il n'y en a pas on n'affiche rien

@zannkukai zannkukai self-assigned this Jun 24, 2021
@zannkukai
Copy link
Contributor

Unable to work with UI public-holding-items project on localhost :'(

@zannkukai zannkukai removed their assignment Jun 25, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 30, 2021
@Garfield-fr
item: add temporary location field
d77e223 
Public view: Display of the temporary_location field according
to the Exbitions/courses and temporary_location cascade.
Professional view: Display of the temporary_location field
in the item views.

* Closes rero/rero-ils#2038

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Jun 30, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 30, 2021
@Garfield-fr
item: add temporary location field
79d2ce7 
Public view: Display of the temporary_location field according
to the Exbitions/courses and temporary_location cascade.
Professional view: Display of the temporary_location field
in the item views.

* Closes rero/rero-ils#2038

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jul 1, 2021
@Garfield-fr
items: add temporary location field
b19fe90 
* Displays the `temporary_location` field according to the
  exhibitions/courses and temporary location cascade on the document
  detailed view of the public interface.
* Displays the `temporary_location` field on the item detailed view of the
  professional interface.

* Closes rero/rero-ils#2038.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jul 2, 2021
@Garfield-fr
items: add temporary location field
a286d30 
* Displays the `temporary_location` field according to the
  exhibitions/courses and temporary location cascade on the document
  detailed view of the public interface.
* Displays the `temporary_location` field on the item detailed view of the
  professional interface.

* Closes rero/rero-ils#2038.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jul 2, 2021
@Garfield-fr
items: add temporary location field
28b0ac5 
* Displays the `temporary_location` field according to the
  exhibitions/courses and temporary location cascade on the document
  detailed view of the public interface.
* Displays the `temporary_location` field on the item detailed view of the
  professional interface.

* Closes rero/rero-ils#2038.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Jul 2, 2021
@Garfield-fr
items: add temporary location field
46a0f83 
* Displays the `temporary_location` field according to the
  exhibitions/courses and temporary location cascade on the document
  detailed view of the public interface.
* Displays the `temporary_location` field on the item detailed view of the
  professional interface.

* Closes rero/rero-ils#2038.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

items: add temporary location field Garfield-fr/rero-ils-ui
2 participants
@pronguen @zannkukai