Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general: fix error 400 bad request #864

Merged
merged 1 commit into from
Jun 8, 2022
Merged

general: fix error 400 bad request #864

merged 1 commit into from
Jun 8, 2022

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: professional ui Professional interface labels Jun 1, 2022
@Garfield-fr Garfield-fr self-assigned this Jun 1, 2022
jma
jma requested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code still need to be removed such as:

rero-ils-ui/projects/admin/src/app/service/app-router-event.service.ts

Line 28 in 972884d

export class AppRouterEventService {
or STORAGE_KEY.

projects/admin/src/app/guard/library.guard.ts Show resolved Hide resolved
@Garfield-fr Garfield-fr requested a review from jma June 2, 2022 07:08
@Garfield-fr Garfield-fr force-pushed the zub-bad-request-guard branch 2 times, most recently from 52fec7a to cbb1ba5 Compare June 2, 2022 08:54
@Garfield-fr
general: fix error 400 bad request
394c09e 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@pronguen pronguen self-requested a review June 7, 2022 16:02
pronguen
pronguen approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficult to test. I opened a document detailed view, waited 10 minutes, and then opened from there the item detailed view. It worked.

@Garfield-fr Garfield-fr merged commit 9d01f05 into rero:staging Jun 8, 2022
@Garfield-fr Garfield-fr deleted the zub-bad-request-guard branch July 11, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@pronguen pronguen pronguen approved these changes

@jma jma jma approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@Garfield-fr Garfield-fr

Labels
f: acquisitions Related to the acquisition module f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error "400 Bad request" sometimes when opening or editing an item
5 participants
@Garfield-fr @jma @pronguen @zannkukai @benerken