Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error "400 Bad request" sometimes when opening or editing an item #2705

Closed
pronguen opened this issue Feb 16, 2022 · 2 comments · Fixed by rero/rero-ils-ui#864
Closed

Error "400 Bad request" sometimes when opening or editing an item #2705

pronguen opened this issue Feb 16, 2022 · 2 comments · Fixed by rero/rero-ils-ui#864
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Milestone
Sprint 56

Comments

@pronguen
Copy link
Contributor

pronguen commented Feb 16, 2022 •
edited
Loading

Describe the bug

See video. This error has been spotted only since v1.8.0.

  • The URL of the item detailed view in the browser navigation bar is wrong in the video: but we see that the target URL in the item brief view is correct...

In the console, we have the following messages:

Maybe linked to #2277 and the PR that corrected it.

To Reproduce

The error is not systematic. See video (cache was disabled).

Expected behavior

No error

TO DO

See comments below

Context

  • server: bib.rero.ch
  • version: v1.8.0

Screenshots

Admin.Mozilla.Firefox.2022-02-16.10-35-33.mp4
@pronguen pronguen added f: professional ui Professional interface bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Feb 16, 2022
@pronguen pronguen mentioned this issue Feb 16, 2022
Closed
@PascalRepond
Copy link
Contributor

According to UCL, this seems to only happen after an inactivity period on the browser tab. Refreshing the page before clicking if the page has been open for a while avoids this problem.

@PascalRepond PascalRepond added the client request Issue reported by production libraries label Mar 8, 2022
@PascalRepond PascalRepond mentioned this issue Mar 14, 2022
Closed
@jma
Copy link
Contributor

jma commented May 16, 2022

The problem comes from here: https://github.com/rero/rero-ils-ui/blob/1ab892a4b6c196d3deadf94ba5f4d3377956ec1f/projects/admin/src/app/service/app-router-event.service.ts#L63

after 30' of inactivity the user is removed from the local storage.

Proposition:

@Garfield-fr Garfield-fr self-assigned this Jun 1, 2022
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 1, 2022
@Garfield-fr
general: fix error 400 bad request
33dcdf1 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Jun 1, 2022
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 2, 2022
@Garfield-fr
general: fix error 400 bad request
5c78a39 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 2, 2022
@Garfield-fr
general: fix error 400 bad request
52fec7a 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 2, 2022
@Garfield-fr
general: fix error 400 bad request
cbb1ba5 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 2, 2022
@Garfield-fr
general: fix error 400 bad request
394c09e 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Jun 7, 2022
@Garfield-fr
general: fix error 400 bad request
8ae07a4 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Jun 8, 2022
@Garfield-fr
general: fix error 400 bad request
9d01f05 
* Closes rero/rero-ils#2705.
* Removes localeStorage user data.
* Updates guards that used the user localeStorage.
* Improves somes guards.
* Adds some tests for guards.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond added this to the Sprint 56 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
Sprint 56
Development

Successfully merging a pull request may close this issue.

general: fix error 400 bad request Garfield-fr/rero-ils-ui
4 participants
@Garfield-fr @jma @pronguen @PascalRepond