Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local_fields: fix local fields orders #905

Merged
merged 1 commit into from
Feb 13, 2023
Merged

local_fields: fix local fields orders #905

merged 1 commit into from
Feb 13, 2023

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Oct 31, 2022 •
edited by PascalRepond
Loading

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test ?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Oct 31, 2022
@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: activity-logs Everything around logging user activities f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: search labels Oct 31, 2022
@zannkukai zannkukai force-pushed the zan-fix-issue-2994 branch 2 times, most recently from 53dfab9 to ed9cf0e Compare December 7, 2022 10:40
@PascalRepond
Copy link
Contributor

Add to commit message : Closes rero/rero-ils#2994

@zannkukai zannkukai force-pushed the zan-fix-issue-2994 branch 2 times, most recently from 8e6290e to dea82d4 Compare January 20, 2023 08:23
@zannkukai zannkukai force-pushed the zan-fix-issue-2994 branch 2 times, most recently from aca1624 to 5a05b09 Compare February 8, 2023 11:28
@github-actions github-actions bot removed f: acquisitions Related to the acquisition module f: search f: activity-logs Everything around logging user activities f: circulation Concerns the circulation interface or backend labels Feb 8, 2023
@zannkukai
local_fields: fix local fields orders.
a5a4af4 
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai marked this pull request as ready for review February 8, 2023 12:21
@zannkukai zannkukai merged commit 5bbb189 into rero:staging Feb 13, 2023
@zannkukai zannkukai deleted the zan-fix-issue-2994 branch February 13, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees

@zannkukai zannkukai

Labels
f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local fields should be displayed in their numeric sequence
4 participants
@zannkukai @PascalRepond @Garfield-fr @lauren-d