Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.4.7 #2294

Merged
merged 1 commit into from
Aug 23, 2021
Merged

release: v1.4.7 #2294

merged 1 commit into from
Aug 23, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Aug 12, 2021

Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added developers From a developer point of view. dev: documentation About changelog, release notes, installation procedures, gh templates... labels Aug 12, 2021
@jma jma force-pushed the maj-release-1.4.7 branch 12 times, most recently from 0b10bfe to b2c22ee Compare August 12, 2021 11:38
@JoelleDosimont
Copy link
Contributor

JoelleDosimont commented Aug 12, 2021

  • Error 500 when accessing "Inventory list"
  • It's impossible to "Import from the web", the page displays this message : "There are no records in this section"
  • Document brief view (pro): a tab is displayed but should not:
    image
  • Facets do not update after tab change
    To reproduce:
    1. Click on the search function on the home page
    2. Click on persons tab
      persons
      If we reload the page, the source facet appears
  • [not blocking] Corporate body subdivisions should be separated by a dot (if repeated)
    image
  • Requests for patrons by librarians are impossible with librarian accounts of a specific library #2234 seems not solved. I tried to do a request and got a message "Demande d'exemplaire. Une erreur est survenue. Merci de réessayer."
  • The pick-up location is corrected in the booking notification, but is still not correct in the availability notification. A new issue was opened: Availability notification: wrong pick-up location name #2295

Issues opened for later

To retest when deployed in ils.test.rero.ch:

@jma
Copy link
Contributor Author

jma commented Aug 12, 2021

  • Error 500 when accessing "Inventory list"
    I got this error on the server: this can be an error of data loading. To be check.
  File "./rero_ils/modules/items/serializers/json.py", line 58, in post_process_serialize_search
    metadata['available'] = item.available
AttributeError: 'NoneType' object has no attribute 'available'

After a new setup the error disappears. This is probably due to previous buggy tests (holdings).

@rerowep
Copy link
Contributor

rerowep commented Aug 16, 2021

  • Unable to duplicate documents for type Article, e-books, serial (maybe others types). when saving the editor display an error messag "The forms contains errors". It works for "books, texts" and "music". Probably not link to this release...

It is working if all empty fields are deleted or filled after duplication.

@rero rero deleted a comment from Garfield-fr Aug 17, 2021
@iGormilhit iGormilhit force-pushed the maj-release-1.4.7 branch 2 times, most recently from 622feee to f6f126f Compare August 23, 2021 12:28
@iGormilhit iGormilhit self-assigned this Aug 23, 2021
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@iGormilhit iGormilhit merged commit de7dd2b into rero:dev Aug 23, 2021
@iGormilhit iGormilhit added this to the v1.4.7 milestone Aug 25, 2021
@jma jma deleted the maj-release-1.4.7 branch January 13, 2022 14:48
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Oct 31, 2022
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Oct 31, 2022
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Dec 7, 2022
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Dec 7, 2022
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Dec 15, 2022
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Jan 13, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Jan 20, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Jan 25, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Feb 6, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Feb 8, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this pull request Feb 8, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this pull request Feb 13, 2023
* Closes rero/rero-ils#2294.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates... developers From a developer point of view.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants