Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default value of genreForm.source #2310

Closed
pronguen opened this issue Aug 18, 2021 · 0 comments · Fixed by #2316
Closed

Wrong default value of genreForm.source #2310

pronguen opened this issue Aug 18, 2021 · 0 comments · Fixed by #2316
Labels
effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

How it works

When adding a genre/form (local entity) or a genre/form with a source, there is a default value of the source in the editor ("rero" for genreForm).

How it should works

There should be no default value.
@pronguen pronguen added effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor triage p-Medium Medium priority (to be solved within 1-2 years) labels Aug 18, 2021
@pronguen pronguen mentioned this issue Aug 18, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr
documents: remove default value on genreForm.source field
f9e58f9 
* Closes rero#2310.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Aug 19, 2021
Closed
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr
documents & holdings: remove default values on optional fields
8657bb8 
* Closes rero#2080.
* Closes rero#2310.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Aug 19, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr
documents & holdings: remove default values on optional fields
03fe43c 
* Closes rero#2080.
* Closes rero#2310.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr
documents & holdings: remove default values on optional fields
99803fe 
* Closes rero#2080.
* Closes rero#2310.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit removed the triage label Aug 25, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 21, 2021
@Garfield-fr
editor: remove default values on optional fields
538ec07 
* Closes rero#2080.
* Closes rero#2310.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@jma jma closed this as completed in fe5653f Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: minor Solved quickly f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
2 participants
@iGormilhit @pronguen