Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: remove default values on optional fields #2316

Merged
merged 1 commit into from
Sep 22, 2021
Merged

editor: remove default values on optional fields #2316

merged 1 commit into from
Sep 22, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Aug 19, 2021 •
edited
Loading

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Aug 19, 2021
@Garfield-fr Garfield-fr self-assigned this Aug 19, 2021
@Garfield-fr Garfield-fr added this to the v1.5.0 milestone Aug 19, 2021
pronguen
pronguen suggested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One correction is missing: field scale.type (in /rero_ils/modules/documents/jsonschemas/documents/document_scale_cartographic-v0.0.1.json)

rero_ils/modules/documents/jsonschemas/documents/document_contribution_organisation-v0.0.1.json Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr requested a review from pronguen August 19, 2021 07:28
@Garfield-fr Garfield-fr marked this pull request as draft August 19, 2021 09:09
@Garfield-fr Garfield-fr marked this pull request as ready for review August 19, 2021 09:47
@Garfield-fr Garfield-fr changed the base branch from dev to v1.5.0 September 21, 2021 08:20
@iGormilhit iGormilhit changed the title documents & holdings: remove default values on optional fields editor: remove default values on optional fields Sep 21, 2021
iGormilhit
iGormilhit suggested changes Sep 21, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title proposition: documents & holdings → editor.

@Garfield-fr
editor: remove default values on optional fields
538ec07 
* Closes rero#2080.
* Closes rero#2310.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit fe5653f into rero:v1.5.0 Sep 22, 2021
@Garfield-fr Garfield-fr deleted the zub-default-value branch March 14, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@benerken benerken benerken approved these changes

@pronguen pronguen pronguen approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@Garfield-fr Garfield-fr

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v1.5.0
5 participants
@Garfield-fr @iGormilhit @pronguen @benerken @rerowep