Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user: password validator #915

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Dec 5, 2022

The password is mandatory if the user is not loaded,
otherwise it is optional

  • Adds validator on new password on change password dialog.
  • Fixes the identifier of the delete button so that it is unique.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface labels Dec 5, 2022
@Garfield-fr Garfield-fr self-assigned this Dec 22, 2022
@github-actions github-actions bot added f: public ui Public interface, as opposed to the professional interface f: user management labels Jan 2, 2023
@Garfield-fr Garfield-fr force-pushed the zub-user-password branch 2 times, most recently from f9309f7 to 467a885 Compare January 16, 2023 13:48
The password is mandatory if the user is not loaded,
otherwise it is optional

* Adds validator on new password on change password dialog.
* Fixes the identifier of the delete button so that it is unique.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit b5beec0 into rero:staging Feb 6, 2023
@Garfield-fr Garfield-fr deleted the zub-user-password branch October 10, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants