Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user: add entrypoints api for the password #3193

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Dec 21, 2022

  • Adds entrypoint to generate a new password.
  • Adds entrypoint to validate a password.
  • Updates users api to use the new password generator and validator.
  • Updates users fixtures to add the password field.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Dependencies:

rero/rero-ils-ui#915
rero/ng-core#531

@Garfield-fr Garfield-fr self-assigned this Dec 21, 2022
@Garfield-fr Garfield-fr marked this pull request as draft December 21, 2022 15:36
@Garfield-fr Garfield-fr force-pushed the zub-password-api branch 2 times, most recently from 1760f15 to 225b08f Compare December 22, 2022 10:36
@github-actions github-actions bot added the f: data migration Data migration from a legacy system or a previous version label Dec 22, 2022
@Garfield-fr Garfield-fr marked this pull request as ready for review December 22, 2022 10:37
@Garfield-fr Garfield-fr marked this pull request as draft January 2, 2023 07:52
@Garfield-fr Garfield-fr changed the title password: add entrypoint to the generate password user: add entrypoints api for the password Jan 2, 2023
@Garfield-fr Garfield-fr force-pushed the zub-password-api branch 5 times, most recently from c3d0863 to e68e618 Compare January 9, 2023 09:56
@github-actions github-actions bot added the dev: fixtures Fixtures data used for ils.test and ilsdev.test label Jan 9, 2023
rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
rero_ils/modules/users/jsonschemas/users/user-v0.0.1.json Outdated Show resolved Hide resolved
rero_ils/modules/utils.py Outdated Show resolved Hide resolved
rero_ils/modules/utils.py Outdated Show resolved Hide resolved
rero_ils/modules/utils.py Outdated Show resolved Hide resolved
rero_ils/modules/utils.py Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-password-api branch 3 times, most recently from 58cfc23 to 3a6bd7a Compare January 16, 2023 12:34
@Garfield-fr Garfield-fr marked this pull request as ready for review January 16, 2023 13:51
@Garfield-fr Garfield-fr requested a review from zannkukai January 16, 2023 13:51
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
rero_ils/modules/users/api.py Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-password-api branch 3 times, most recently from 586b52c to dc3f7f3 Compare January 18, 2023 14:14
* Adds entrypoint to generate a new password.
* Adds entrypoint to validate a password.
* Updates users api to use the new password generator and validator.
* Updates users fixtures to add the password field.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit d437a4f into rero:US-Access Jan 19, 2023
@Garfield-fr Garfield-fr deleted the zub-password-api branch October 10, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants