The transaction history should base on the operation logs and not on the loans

[iGormilhit]

How it works

In the history tab of the patron profile (public interface) and in the patron account of the professional interface, the loan transaction history has errors:

1. display of the date at which the item should have been returned, not the actual checkin date. This is the case in the checkin column and in the transaction history itself (see screenshot below).
   

2. sometimes no display of a line (because the item was deleted, or for other reasons)
   Example in production: patron.pid:27115 (vs)
   

How it should works

All data are recovered from the operation logs:

1. The checkin date displayed should be the actual checkin date (in my example, it was the 2020-09-17, not the 2020-10-15).
   The checkin date is displayed for each fee in the fee tab.
2. Loans on deleted items are still displayed

Related issue

• Request date shouldn't be updated after validation Request date shouldn't be updated after validation #1704

[zannkukai]

I don't understand this issue. The main display date is the real checkin date (the date where the book was returned at the library). Do you want to display as main date the "expected checking date" ? (As this book is borrowed the 14/09, the end limit for this loan should be 15/10 ?)

[ManaDeweerdt]

It displays the due date in place of the actual CI date when the item is returned to a library different from the library where the checkout has been done.

[iGormilhit]

@zannkukai : @ManaDeweerdt explained it perfectly.

[zannkukai]

I think we view here the limit of the circulation process. Invenio-circulation doesn't keep operation history. We have 3 potential dates : the start_date the end_date and the transaction_date. These dates can be update during the circulation process (@BadrAly could correct me if I'm wrong).

• start_date is always the checkout_date (the loan creation date)
• end_date is either the expected due date (when the item is not yet returned on shelf), or the last operation date (when item is returned on shelf).
• transaction_date is the last operation date (CI, CO, Transit, Cancelled, ...)

The problem describe here is caused by the fact that item goes IN_TRANSIT_TO_HOUSE state. In this case, the transaction_date is the CI date, but end_date is still the expected date. After a CI operation on the item in the item home library, the transaction_date will be update to this new date, and the end_date will be updated to this new date too ! But this new date isn't the real patron CI operation date ! And (with my knowledge) it's not possible to know when the patron CI operation date was done !

[iGormilhit]

Will be possible to fix after the transaction history functionality.
Depends on https://tree.taiga.io/project/rero21-reroils/us/1913