Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request date shouldn't be updated after validation #1704

Closed
ManaDeweerdt opened this issue Feb 17, 2021 · 4 comments · Fixed by rero/rero-ils-ui#793
Closed

Request date shouldn't be updated after validation #1704

ManaDeweerdt opened this issue Feb 17, 2021 · 4 comments · Fixed by rero/rero-ils-ui#793
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months)

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 17, 2021 •
edited
Loading

Describe the bug

When a request is validated, the request date of the item detail view changes to the validated date.
Ex: Katie made a request the 16th.
image
I validated the request of Katie on the 17th. The request date changed to 17th.
image

To Reproduce

  1. Go to the request section.
  2. Click on a barcode and add several new requests on the same item.
  3. On the request section, validate the request.
  4. See the item detail view.

Expected behavior

The request date shouldn't change to the transaction date. Otherwise, the staff will have difficulties to follow the request queue.

Context
@ManaDeweerdt ManaDeweerdt added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking p-Low Low priority labels Feb 17, 2021
@zannkukai
Copy link
Contributor

Seems inked to #1227

@iGormilhit
Copy link

Seems linked to #1227

@zannkukai Indeed.

@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface and removed triage labels Feb 23, 2021
@iGormilhit iGormilhit mentioned this issue Feb 23, 2021
Closed
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) and removed p-Low Low priority labels Feb 23, 2021
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Aug 11, 2021
@pronguen pronguen mentioned this issue Aug 11, 2021
Closed
@zannkukai
Copy link
Contributor

@ManaDeweerdt I did some tests and it seems solved. Could you confirm (and close if necessary)

@zannkukai zannkukai self-assigned this Jan 19, 2022
@ManaDeweerdt
Copy link
Contributor Author

I've tested on https://ilsdev.test.rero.ch/ and I still have the same issue.

zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jan 20, 2022
@zannkukai
request: display the request time
6de3fd1 
Add the request time to the request date into the `requestedBy` box. At
this time, only the date was displayed : it was not precise enough.
Closes rero/rero-ils#1704.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>

 Please enter the commit message for your changes. Lines starting
@zannkukai zannkukai mentioned this issue Jan 20, 2022
Merged
7 tasks
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Jan 25, 2022
@zannkukai
request: display the request time
d6c739a 
Add the request time to the request date into the `requestedBy` box. At
this time, only the date was displayed : it was not precise enough.
Closes rero/rero-ils#1704.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>

 Please enter the commit message for your changes. Lines starting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

request: display the request time zannkukai/rero-ils-ui
4 participants
@iGormilhit @pronguen @zannkukai @ManaDeweerdt