Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The link to the patron profile is not translated in the public interface. #1283

Closed
pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by #1413
Closed

The link to the patron profile is not translated in the public interface. #1283

pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by #1413
Assignees
@AoNoOokami
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface translations Translations
Milestone
v0.14.1

Comments

@pronguen
Copy link
Contributor

Describe the bug
In the public interface, the link to the patron profile is not translated.

To Reproduce

  1. Log in as a patron
  2. Switch to a language other than English
  3. Click on your initials and see

Expected behavior
Should be translated

Context

  • server: ilsdev.test.rero.ch
  • version: rero-ils version 1bc8cd8, rero-ils-ui version 7291c288

Proposed by the pilot libraries

Screenshots

image
@pronguen pronguen added translations Translations f: public ui Public interface, as opposed to the professional interface triage bug Breaks something but is not blocking labels Oct 12, 2020
@pronguen pronguen modified the milestones: v0.13.0, v0.14.0 Oct 13, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Oct 14, 2020
app: fix several issues
1fb7e1e 
* Updates help link in frontpage.
* Translates patron 'Profile' menu.
* Closes rero#1277.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Oct 14, 2020
Merged
6 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Oct 14, 2020
app: fix several issues
e0eae0b 
* Updates help link in frontpage.
* Removes useless template.
* Translates patron 'Profile' menu.
* Closes rero#1277.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami self-assigned this Oct 14, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Oct 21, 2020
app: fix several issues
4780f42 
* Updates help link in frontpage.
* Removes useless template.
* Translates patron 'Profile' menu.
* Closes rero#1277.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
ui: fix translation issues
e89a12f 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1283.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Nov 10, 2020
Merged
6 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
ui: fix translation issues
6bc51ec 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1283.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
frontpage: fix patron profile link translation
15a62e1 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 11, 2020
frontpage: fix patron profile link translation
339c755 
* Fixes the translation of the patron profile link.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 11, 2020
frontpage: fix patron profile link translation
e0fdc8e 
* Fixes the translation of the patron profile link.
* Closes rero#1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami modified the milestones: v0.14.0, v0.14.1 Nov 18, 2020
AoNoOokami pushed a commit that referenced this issue Nov 18, 2020
@AoNoOokami
frontpage: fix patron profile link translation
ce087b1 
* Fixes the translation of the patron profile link.
* Closes #1283.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@iGormilhit iGormilhit removed the triage label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface translations Translations
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging a pull request may close this issue.

frontpage: fix patron profile link translation AoNoOokami/rero-ils
3 participants
@iGormilhit @pronguen @AoNoOokami