Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message for a request that is denied is partially untranslated. #1367

Closed
pronguen opened this issue Nov 4, 2020 · 0 comments · Fixed by #1429
Closed

Message for a request that is denied is partially untranslated. #1367

pronguen opened this issue Nov 4, 2020 · 0 comments · Fixed by #1429
Assignees
@AoNoOokami
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface translations Translations

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 4, 2020

Describe the bug

In the pro interface, the request button is disabled for item that cannot be requested. The tooltip message is only partially translated.

To Reproduce

  1. Edit a location and disable the requests for it
  2. Try to request an item of this location from the pro interface
  3. See message

Expected behavior
Should be translated

Context

  • server: ilsdev.test.rero.ch
  • version: rero-ils version 1bc8cd8, rero-ils-ui version 7291c288

Proposed by the pilot libraries

Screenshots

image
@pronguen pronguen added translations Translations triage bug Breaks something but is not blocking labels Nov 4, 2020
@AoNoOokami AoNoOokami self-assigned this Nov 9, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
issue: fix the translation of the patron profile link
6458a22 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Closes rero#1367.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
issue: fix the translation of the patron profile link
2c6d374 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
ui: fix translation issues
15f7663 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 9, 2020
ui: fix translation issues
4d89945 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Nov 9, 2020
Merged
6 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
ui: fix translation issues
e89a12f 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1283.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
ui: fix translation issues
6bc51ec 
* Fixes the translation of the patron profile link in menu by loading the menu at each app
request, not only the first time.
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1283.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 10, 2020
ui: fix translation issues
ae4a53e 
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Nov 10, 2020
Merged
6 tasks
AoNoOokami pushed a commit that referenced this issue Nov 18, 2020
@AoNoOokami
ui: fix translation issues
c0781d2 
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes #1367.
* Closes #1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@iGormilhit iGormilhit added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend and removed triage labels Nov 19, 2020
@iGormilhit iGormilhit changed the title Message for request denied is only partially translated. Message for a request that is denied is partially untranslated. Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface translations Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: fix translation issues AoNoOokami/rero-ils
3 participants
@iGormilhit @pronguen @AoNoOokami