Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: fix translation issues #1429

Merged
merged 1 commit into from
Nov 18, 2020
Merged

ui: fix translation issues #1429

merged 1 commit into from
Nov 18, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 10, 2020 •
edited
Loading

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

TO close issues mentioned above.

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

N/A

How to test?

See issues description

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

ui: fix translation issues
ae4a53e 
* Adds the 'request denied'  message to the string to translate.
* Adds note types (label AND value) to the string to translate.
* Closes rero#1367.
* Closes rero#1319.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami self-assigned this Nov 10, 2020
@AoNoOokami AoNoOokami added this to the v0.14.0 milestone Nov 10, 2020
@AoNoOokami AoNoOokami added the translations Translations label Nov 11, 2020
@AoNoOokami AoNoOokami modified the milestones: v0.14.0, v0.15.0 Nov 11, 2020
@AoNoOokami AoNoOokami modified the milestones: v0.15.0, v0.14.1 Nov 18, 2020
@AoNoOokami AoNoOokami merged commit c0781d2 into rero:dev Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@AoNoOokami AoNoOokami

Labels
translations Translations
Projects
None yet
Milestone
v0.14.1
4 participants
@AoNoOokami @iGormilhit @zannkukai @BadrAly