Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A call number (1st and 2nd) should not have a minimum caracter constraint. #1284

Closed
pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by #1244
Closed

A call number (1st and 2nd) should not have a minimum caracter constraint. #1284

pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by #1244
Assignees
@BadrAly
Labels
f: editor Concerns editor based on JSON schema AND custom editor

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 12, 2020 •
edited
Loading

How it works

In the item editor and holding editor, a call number should have at least 4 caracters.

How it should works

1st and 2nd call numbers should have no constraints.

Context

Proposed by pilot libraries
@pronguen pronguen added f: editor Concerns editor based on JSON schema AND custom editor triage labels Oct 12, 2020
@BadrAly BadrAly self-assigned this Oct 13, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 13, 2020
holdings: add optional fields for holdings display
6529959 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have now a minimum caracter constraint of 1.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 13, 2020
holdings: add optional fields for holdings display
cf05fb5 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum caracter constraint.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Oct 13, 2020
Merged
6 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 13, 2020
holdings: add optional fields for holdings display
7fba716 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 13, 2020
holdings: add optional fields for holdings display
8806950 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 13, 2020
holdings: add optional fields for holdings display
1625ee4 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 14, 2020
holdings: add optional fields for holdings display
845a0f0 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 14, 2020
holdings: add optional fields for holdings display
34f53ae 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 14, 2020
holdings: add optional fields for holdings display
1132fac 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

Issues with status deleted are not displayed in the public interface.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 14, 2020
holdings: add optional fields for holdings display
709f62b 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

Issues with status deleted are not displayed in the public interface.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 14, 2020
holdings: add optional fields for holdings display
2edcfac 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

Issues with status deleted are not displayed in the public interface.

* Closes rero#1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Oct 14, 2020
holdings: add optional fields for holdings display
8b88dd7 
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
- enumerationAndChronology
- supplementaryContent
- index
- missing_issues
- notes

The new field second_call_number is available for
all types of holdings records

Item and holdings call numbers have no minimum character constraint.

Issues with status deleted are not displayed in the public interface.

* Closes #1284
* Removes the condition to have an item second call number only
if first call number exist.
* Adapts tests and fixtures accordingly.
* Adapts the public interface to display the new fields.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

holdings: add optional fields for holdings display BadrAly/rero-ils
3 participants
@iGormilhit @pronguen @BadrAly