-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
holdings: add optional fields for holdings display #1244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
12 times, most recently
from
October 8, 2020 11:14
1766c9e
to
0169013
Compare
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
from
October 8, 2020 12:36
0169013
to
5ca12b9
Compare
zannkukai
approved these changes
Oct 9, 2020
benerken
approved these changes
Oct 9, 2020
Garfield-fr
approved these changes
Oct 12, 2020
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
7 times, most recently
from
October 13, 2020 10:32
7fba716
to
8806950
Compare
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
from
October 13, 2020 14:05
8806950
to
1625ee4
Compare
pronguen
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All the notes should be displayed in the professional interface, with a dedicated label (currently: only general note). In public interface, it is correct: only display the general note.
- Why is the "Duplicate" button not aligned with the others?
- The line breaks inside the notes should be displayed as line breaks in pro/public interface. This can also be realised in US 1724
|
|
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
from
October 14, 2020 08:55
1625ee4
to
845a0f0
Compare
pronguen
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- holdings wihtout items should be display also in the public view (there is the collection description)
- Ideally without the expand button and without "No items received"
- items/issues that have status deleted should not be displayed in public interface (an issue can be opened for that...)
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
from
October 14, 2020 12:33
845a0f0
to
34f53ae
Compare
pronguen
approved these changes
Oct 14, 2020
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
2 times, most recently
from
October 14, 2020 12:36
1132fac
to
709f62b
Compare
With this commit, new optional fields are allowed for the holdings of type serial. The fields are: - enumerationAndChronology - supplementaryContent - index - missing_issues - notes The new field second_call_number is available for all types of holdings records Item and holdings call numbers have no minimum character constraint. Issues with status deleted are not displayed in the public interface. * Closes rero#1284 * Removes the condition to have an item second call number only if first call number exist. * Adapts tests and fixtures accordingly. * Adapts the public interface to display the new fields. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-add-holdings-fields
branch
from
October 14, 2020 13:25
709f62b
to
2edcfac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, new optional fields are allowed for
the holdings of type serial. The fields are:
The new field second_call_number is available for
all types of holdings records
Item and holdings call numbers have no minimum character constraint.
Issues with status deleted are not displayed in the public interface.
if first call number exist.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/taskboard/sprint-35-106?kanban-status=1224894
How to test?
bootstrap
+setup
To display a serial holdings with optional field, display the following document in the public interface:
~/global/search/documents?q=R003826164&page=1&size=10
Code review check list