Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The canton dropdown should appear only if the country Switzerland is selected. #1285

Closed
pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by #1301
Closed

The canton dropdown should appear only if the country Switzerland is selected. #1285

pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by #1301
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor

Comments

@pronguen
Copy link
Contributor

How it works

Currently, in the document editor, it is possible to add a Swiss canton (field canton inside provisionActivity) to another country than Switzerland.

Improvement suggestion

The canton dropdown should appear only if the country Switzerland is selected.

Context

Proposed by pilot libraries
@pronguen pronguen added enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor triage labels Oct 12, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 13, 2020
@zannkukai
document: canton field only available for switzerland
682d68e 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes rero#1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai removed the triage label Oct 13, 2020
@zannkukai zannkukai self-assigned this Oct 13, 2020
@zannkukai zannkukai mentioned this issue Oct 13, 2020
Merged
6 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 19, 2020
@zannkukai
document: canton field only available for switzerland
68ebc01 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes rero#1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 20, 2020
@zannkukai
document: canton should only available for switzerland
3c846dd 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes rero#1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Oct 28, 2020
@zannkukai
document: canton should only available for switzerland
fdf3267 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes #1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Nov 2, 2020
@zannkukai
document: canton should only available for switzerland
a29f02a 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes #1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
BadrAly pushed a commit that referenced this issue Nov 5, 2020
@zannkukai
document: canton should only available for switzerland
ec3699d 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes #1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Nov 5, 2020
@zannkukai
document: canton should only available for switzerland
7b761ef 
The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes #1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document: canton field only available for switzerland zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai