Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: canton field only available for switzerland #1301

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

zannkukai
Copy link
Contributor

The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes #1285

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • In the document editor, play with country field into provisionActivity section. When 'Switzerland' (sz) is selected the canton field should appears, otherwise the field is hidden.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai requested review from jma and rerowep October 13, 2020 14:50
@zannkukai zannkukai self-assigned this Oct 13, 2020
@zannkukai zannkukai marked this pull request as ready for review October 14, 2020 07:07
@zannkukai zannkukai added this to the v0.14.0 milestone Oct 14, 2020
@zannkukai zannkukai force-pushed the zan-canton-only-for-switzerland branch from 682d68e to 68ebc01 Compare October 19, 2020 09:31
@jma
Copy link
Contributor

jma commented Oct 19, 2020

The first line of the commit message do not contain a verb.

The canton field should only be available when the country 'Switzerland'
was selected in the provisionActitivy country field.

Closes rero#1285

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-canton-only-for-switzerland branch from 68ebc01 to 3c846dd Compare October 20, 2020 07:16
@zannkukai zannkukai changed the base branch from dev to v0.14 October 28, 2020 08:55
@zannkukai zannkukai merged commit fdf3267 into rero:v0.14 Oct 28, 2020
@zannkukai zannkukai deleted the zan-canton-only-for-switzerland branch October 28, 2020 09:03
@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The canton dropdown should appear only if the country Switzerland is selected.
4 participants