Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The manual blocking of a user should block also the renewals. #1383

Closed
pronguen opened this issue Nov 5, 2020 · 0 comments · Fixed by #1502
Closed

The manual blocking of a user should block also the renewals. #1383

pronguen opened this issue Nov 5, 2020 · 0 comments · Fixed by #1502
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Milestone
v0.15.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020 •
edited
Loading

How it works

Currently, it only blocks checkouts and requests.

Improvement suggestion

It should block also the renewals.

In that way, this block will have the same effect than the limits defined in the patron type (per fee amount, per overdue items).

Context

Proposed by pilot libraries
@pronguen pronguen added enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend triage labels Nov 5, 2020
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) p-High High priority (to be solved in the 2-3 next months) and removed triage p-Medium Medium priority (to be solved within 1-2 years) labels Nov 19, 2020
@zannkukai zannkukai self-assigned this Nov 25, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 25, 2020
@zannkukai
circulation: add control on circulation operation.
565145d 
Closes rero#1470
If a circulation policy disallow checkout operation, the error message
returned was not user friendly. This commit add a check for checkout
operation on cipo; this check return a better error message.

Closes rero#1383
If a patron is blocked for any reasons, this user couldn't extend any
active loan.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Nov 25, 2020
Merged
6 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 25, 2020
@zannkukai
circulation: add control on circulation operation.
a3ef7db 
Closes rero#1470
If a circulation policy disallow checkout operation, the error message
returned was not user friendly. This commit add a check for checkout
operation on cipo; this check return a better error message.

Closes rero#1383
If a patron is blocked for any reasons, this user couldn't extend any
active loan.

Closes rero#1507
Fixes 'status' facet problem on items result list. Despite if user
choose a status to faceting the results, the facet value didn't apply.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 26, 2020
@zannkukai
circulation: add control on circulation operation
a924b92 
Closes rero#1470
If a circulation policy disallow checkout operation, the error message
returned was not user friendly. This commit add a check for checkout
operation on circulation policy; this check return a better error
message.

Closes rero#1383
If a patron is blocked for any reasons, this user shouldn't be able to
extend any active loan.

Closes rero#1507
Fixes 'status' facet problem on items result list. Despite if user
select a status facet to filter the results, the facet value didn't
apply.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added this to the v1.0.0 milestone Nov 26, 2020
zannkukai added a commit that referenced this issue Nov 30, 2020
@zannkukai
circulation: add control on circulation operation
f6c73a8 
Closes #1470
If a circulation policy disallow checkout operation, the error message
returned was not user friendly. This commit add a check for checkout
operation on circulation policy; this check return a better error
message.

Closes #1383
If a patron is blocked for any reasons, this user shouldn't be able to
extend any active loan.

Closes #1507
Fixes 'status' facet problem on items result list. Despite if user
select a status facet to filter the results, the facet value didn't
apply.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit modified the milestones: v1.0.0, v0.15.0 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

circulation: add control on circulation operation zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai