circulation: add control on circulation operation #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
added
f: circulation
zannkukai
force-pushed
the
zan-fix-cipo-checkout
branch
from
565145d to
a3ef7db
Compare
Garfield-fr
approved these changes
Nov 26, 2020
iGormilhit
changed the title
iGormilhit
suggested changes
Nov 26, 2020
There was a problem hiding this comment.
Minor commit changes:
circulation: add control on circulation operation
Closes rero/rero-ils#1470
If a circulation policy disallow checkout operation, the error message
returned was not user friendly. This commit add a check for checkout
operation on circulation policy; this check return a better error
message.
Closes rero/rero-ils#1383
If a patron is blocked for any reasons, this user shouldn't be able to
extend any active loan.
Closes rero/rero-ils#1507
Fixes 'status' facet problem on items result list. Despite if user
select a status facet to filter the results, the facet value didn't
apply.
No trailing dot on commit title.
lauren-d
reviewed
Nov 26, 2020
Closes rero#1470 If a circulation policy disallow checkout operation, the error message returned was not user friendly. This commit add a check for checkout operation on circulation policy; this check return a better error message. Closes rero#1383 If a patron is blocked for any reasons, this user shouldn't be able to extend any active loan. Closes rero#1507 Fixes 'status' facet problem on items result list. Despite if user select a status facet to filter the results, the facet value didn't apply. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-cipo-checkout
branch
from
a3ef7db to
a924b92
Compare
lauren-d
approved these changes
Nov 26, 2020
iGormilhit
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1470
If a circulation policy disallow checkout operation, the error message
returned was not user friendly. This commit add a check for checkout
operation on cipo; this check return a better error message.
Closes #1383
If a patron is blocked for any reasons, this user couldn't extend any
active loan.
Closes #1507
Fixes 'status' facet problem on items result list. Despite if user
choose a status to faceting the results, the facet value didn't apply.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list