Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset password e-mails are too terse and untranslated #1387

Closed
pronguen opened this issue Nov 5, 2020 · 0 comments · Fixed by #1589
Closed

Reset password e-mails are too terse and untranslated #1387

pronguen opened this issue Nov 5, 2020 · 0 comments · Fixed by #1589
Assignees
@AoNoOokami
Labels
enhancement Improvement of an existing feature f: user management p-Medium Medium priority (to be solved within 1-2 years) translations Translations
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020

Describe the bug

The reset password e-mails (reset + confirmation) are not or partially translated.

To Reproduce

  1. Ask to reset your password
  2. See e-mail received
  3. Reset the password
  4. See confirmation

Expected behavior
The content is trnaslated, more exhaustive and nicer! See below

SUBJECT: RERO ID password reset

Dear [first name and last name],

Someone requested that the password for your RERO ID account be reset.

Reset my password(+link)

If you didn't request this, you can ignore this e-mail. Your password won't change until you create a new password.

Best regards

Your library
http:://ils.test.rero.ch/(adapt this link according to the instance)

Template: https://postmarkapp.com/blog/password-reset-templates-best-practices

SUBJECT: Your RERO ID password has been reset

Dear [first name and last name],

Your password has been successfully reset.

Best regards

Your library
http:://ils.test.rero.ch/(adapt this link according to the instance)

Context

  • server: ilspilot.test.rero.ch

Proposed by the pilot libraries

Screenshots

Reset
image

Confirmation
image
@pronguen pronguen added f: user management triage bug Breaks something but is not blocking labels Nov 5, 2020
@iGormilhit iGormilhit added translations Translations enhancement Improvement of an existing feature p-Medium Medium priority (to be solved within 1-2 years) and removed triage bug Breaks something but is not blocking labels Nov 19, 2020
@iGormilhit iGormilhit added this to the v1.0.0 milestone Nov 30, 2020
@AoNoOokami AoNoOokami self-assigned this Jan 5, 2021
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 5, 2021
notification: improve password reset notifications
4a2dfe6 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Jan 5, 2021
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 6, 2021
notification: improve password reset notifications
67b6ee1 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 8, 2021
notification: improve password reset notifications
7e377ae 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami linked a pull request Jan 8, 2021 that will close this issue
notification: improve password reset notifications #1589
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 12, 2021
notification: improve password reset notifications
f529230 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 13, 2021
notification: improve password reset notifications
4ca50fa 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 13, 2021
notification: improve password reset notifications
adb9cda 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 13, 2021
notification: improve password reset notifications
d7d4a29 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 13, 2021
notification: improve password reset notifications
e446e95 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 18, 2021
notification: improve password reset notifications
abfe978 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Jan 18, 2021
Closed
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 19, 2021
notification: improve password reset notifications
0b94c46 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 19, 2021
notification: improve password reset notifications
871ed88 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 19, 2021
notification: improve password reset notifications
521cff2 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 19, 2021
notification: improve password reset notifications
303de18 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jan 20, 2021
notification: improve password reset notifications
9b1adb9 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes rero#1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit that referenced this issue Jan 25, 2021
@AoNoOokami
notification: improve password reset notifications
cddfaeb 
* Improves reset instruction notification.
* Adds a custom template for reset notice notification.
* Closes #1387.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@iGormilhit iGormilhit changed the title Reset password e-mails are to short and not translated Reset password e-mails are too terse and untranslated Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
enhancement Improvement of an existing feature f: user management p-Medium Medium priority (to be solved within 1-2 years) translations Translations
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

notification: improve password reset notifications AoNoOokami/rero-ils
3 participants
@iGormilhit @pronguen @AoNoOokami