Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the creation of a patron fails, the reset password email is sent anyway #1615

Closed
AoNoOokami opened this issue Jan 18, 2021 · 0 comments
Closed

When the creation of a patron fails, the reset password email is sent anyway #1615

AoNoOokami opened this issue Jan 18, 2021 · 0 comments
Labels
bug Breaks something but is not blocking f: notifications f: user management p-Low Low priority stale Stale or no longer relevant

Comments

@AoNoOokami
Copy link
Contributor

Describe the bug
This issue is difficult to reproduce but according to the code, when the creation of a patron fails, the reset password email will be sent anyway.

This issue was highlighted while working on #1387.

To Reproduce

As I said, this is tricky to reproduce. A unit test should be added (or modified) to manage this case.

Expected behavior

When the creation of a patron fails, no e-mail is sent.

Context

rero-ils v0.15.0

Screenshots

Additional context
@AoNoOokami AoNoOokami added triage bug Breaks something but is not blocking labels Jan 18, 2021
@iGormilhit iGormilhit added f: notifications p-Medium Medium priority (to be solved within 1-2 years) f: user management and removed triage labels Jan 19, 2021
@iGormilhit iGormilhit added p-Low Low priority and removed p-Medium Medium priority (to be solved within 1-2 years) labels Jan 27, 2021
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
user: add new fields
377ebb6 
* Replaces the phone field by 4 new home, buisness, mobile, other phone
  fields in the user data model.
* Adds country, gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all the user from the patron data model.
* Adds the secound address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
fdf434b 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Mar 1, 2021
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
5480e33 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
3cc4c88 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
702696c 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
a9f6dc7 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
fb8f162 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
dd8ef3f 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes #1724, #1634, #1615, #1490, #1467, #1318, #1384, #1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
30bf6ec 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes #1724, #1634, #1615, #1490, #1467, #1318, #1384, #1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@PascalRepond PascalRepond added the stale Stale or no longer relevant label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: notifications f: user management p-Low Low priority stale Stale or no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @AoNoOokami @PascalRepond